Remove extra apm update for HM responses

vankoven · vankoven · commit 3b930c154778 · 2019-02-06T18:54:35.000+05:00
The issue was noticed in comment #1169 (comment) Anyway tfw_apm_update() in tfw_http_hm_drop_resp() doesn't look good.
diff --git a/tempesta_fw/http.c b/tempesta_fw/http.c
@@ -2787,8 +2787,6 @@ tfw_http_hm_drop_resp(TfwHttpResp *resp)
 	TfwHttpReq *req = resp->req;
 
 	tfw_connection_unlink_msg(resp->conn);
-	tfw_apm_update(((TfwServer *)resp->conn->peer)->apmref,
-		       resp->jrxtstamp, resp->jrxtstamp - req->jtxtstamp);
 	tfw_http_conn_msg_free((TfwHttpMsg *)resp);
 	tfw_http_msg_free((TfwHttpMsg *)req);
 }

Original file line number	Diff line number	Diff line change
`@@ -2787,8 +2787,6 @@ tfw_http_hm_drop_resp(TfwHttpResp *resp)`
`2787`	`2787`	`TfwHttpReq *req = resp->req;`
`2788`	`2788`
`2789`	`2789`	`tfw_connection_unlink_msg(resp->conn);`
`2790`		`- tfw_apm_update(((TfwServer *)resp->conn->peer)->apmref,`
`2791`		`- resp->jrxtstamp, resp->jrxtstamp - req->jtxtstamp);`
`2792`	`2790`	`tfw_http_conn_msg_free((TfwHttpMsg *)resp);`
`2793`	`2791`	`tfw_http_msg_free((TfwHttpMsg *)req);`
`2794`	`2792`	`}`