Skip to content

Commit 705213c

Browse files
author
itsdalmo
committed
Fix e2e test for individual metadata files
1 parent a0ac999 commit 705213c

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

e2e/e2e_test.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ func TestGetAndPutE2E(t *testing.T) {
153153
putParameters resource.PutParameters
154154
versionString string
155155
metadataString string
156+
metadataFiles map[string]string
156157
expectedCommitCount int
157158
expectedCommits []string
158159
}{
@@ -169,10 +170,20 @@ func TestGetAndPutE2E(t *testing.T) {
169170
Commit: targetCommitID,
170171
CommittedDate: time.Time{},
171172
},
172-
getParameters: resource.GetParameters{},
173-
putParameters: resource.PutParameters{},
174-
versionString: `{"pr":"4","commit":"a5114f6ab89f4b736655642a11e8d15ce363d882","committed":"0001-01-01T00:00:00Z"}`,
175-
metadataString: `[{"name":"pr","value":"4"},{"name":"url","value":"https://github.com/itsdalmo/test-repository/pull/4"},{"name":"head_name","value":"my_second_pull"},{"name":"head_sha","value":"a5114f6ab89f4b736655642a11e8d15ce363d882"},{"name":"base_name","value":"master"},{"name":"base_sha","value":"93eeeedb8a16e6662062d1eca5655108977cc59a"},{"name":"message","value":"Push 2."},{"name":"author","value":"itsdalmo"}]`,
173+
getParameters: resource.GetParameters{},
174+
putParameters: resource.PutParameters{},
175+
versionString: `{"pr":"4","commit":"a5114f6ab89f4b736655642a11e8d15ce363d882","committed":"0001-01-01T00:00:00Z"}`,
176+
metadataString: `[{"name":"pr","value":"4"},{"name":"url","value":"https://github.com/itsdalmo/test-repository/pull/4"},{"name":"head_name","value":"my_second_pull"},{"name":"head_sha","value":"a5114f6ab89f4b736655642a11e8d15ce363d882"},{"name":"base_name","value":"master"},{"name":"base_sha","value":"93eeeedb8a16e6662062d1eca5655108977cc59a"},{"name":"message","value":"Push 2."},{"name":"author","value":"itsdalmo"}]`,
177+
metadataFiles: map[string]string{
178+
"pr": "4",
179+
"url": "https://github.com/itsdalmo/test-repository/pull/4",
180+
"head_name": "my_second_pull",
181+
"head_sha": "a5114f6ab89f4b736655642a11e8d15ce363d882",
182+
"base_name": "master",
183+
"base_sha": "93eeeedb8a16e6662062d1eca5655108977cc59a",
184+
"message": "Push 2.",
185+
"author": "itsdalmo",
186+
},
176187
expectedCommitCount: 10,
177188
expectedCommits: []string{"Merge commit 'a5114f6ab89f4b736655642a11e8d15ce363d882'"},
178189
},
@@ -325,18 +336,7 @@ func TestGetAndPutE2E(t *testing.T) {
325336
metadata := readTestFile(t, filepath.Join(dir, ".git", "resource", "metadata.json"))
326337
assert.Equal(t, tc.metadataString, metadata)
327338

328-
files := map[string]string{
329-
"pr": "4",
330-
"url": "https://github.com/itsdalmo/test-repository/pull/4",
331-
"head_name": "my_second_pull",
332-
"head_sha": "a5114f6ab89f4b736655642a11e8d15ce363d882",
333-
"base_name": "master",
334-
"base_sha": "93eeeedb8a16e6662062d1eca5655108977cc59a",
335-
"message": "Push 2.",
336-
"author": "itsdalmo",
337-
}
338-
339-
for filename, expected := range files {
339+
for filename, expected := range tc.metadataFiles {
340340
actual := readTestFile(t, filepath.Join(dir, ".git", "resource", filename))
341341
assert.Equal(t, expected, actual)
342342
}

0 commit comments

Comments
 (0)