🐛 Fix BLOB default value (#36)

Author: techouse

mysql_to_sqlite3/transporter.py

@@ -253,6 +253,24 @@ def _translate_type_from_mysql_to_sqlite(
     def _translate_default_from_mysql_to_sqlite(
         cls, column_default=None, column_type=None
     ):
+        if isinstance(column_default, six.binary_type):
+            if column_type in {
+                "BIT",
+                "BINARY",
+                "BLOB",
+                "LONGBLOB",
+                "MEDIUMBLOB",
+                "TINYBLOB",
+                "VARBINARY",
+            }:
+                if six.PY2:
+                    try:
+                        return "DEFAULT x'{}'".format(column_default.encode("hex"))
+                    except AttributeError:
+                        pass
+                else:
+                    return "DEFAULT x'{}'".format(column_default.hex())
+
         try:
             column_default = column_default.decode()
         except (UnicodeDecodeError, AttributeError):

tests/models.py

@@ -96,7 +96,12 @@ class Misc(Base):
     id = Column(Integer, primary_key=True)
     big_integer_field = Column(BigInteger, default=0)
     big_integer_unsigned_field = Column(BIGINT(unsigned=True), default=0)
-    large_binary_field = Column(LargeBinary, nullable=True)
+    if environ.get("LEGACY_DB", "0") == "0":
+        large_binary_field = Column(
+            LargeBinary, nullable=True, default=b"Lorem ipsum dolor"
+        )
+    else:
+        large_binary_field = Column(LargeBinary, nullable=True)
     boolean_field = Column(Boolean, default=False)
     char_field = Column(CHAR(255), nullable=True)
     date_field = Column(Date, nullable=True)

tests/unit/mysql_to_sqlite3_test.py

@@ -225,6 +225,37 @@ def test_translate_default_numbers_from_mysql_to_sqlite(
             == sqlite_default_translation
         )
 
+    @pytest.mark.parametrize(
+        "column_default, sqlite_default_translation",
+        [
+            pytest.param(b"", "DEFAULT x''", id="b''"),
+            pytest.param(b"-1", "DEFAULT x'2d31'", id="b'-1'"),
+            pytest.param(b"0", "DEFAULT x'30'", id="b'0'"),
+            pytest.param(b"1", "DEFAULT x'31'", id="b'1'"),
+            pytest.param(
+                b"-1234567890", "DEFAULT x'2d31323334353637383930'", id="b'-1234567890'"
+            ),
+            pytest.param(
+                b"1234567890", "DEFAULT x'31323334353637383930'", id="b'1234567890'"
+            ),
+            pytest.param(b"SQLite", "DEFAULT x'53514c697465'", id="b'SQLite'"),
+            pytest.param(
+                b"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam pretium, purus vitae sollicitudin varius, nisi lectus vehicula dui, ut dignissim felis dolor blandit justo. Donec eleifend lectus ut feugiat rhoncus. Donec erat nibh, dapibus nec diam id, lacinia lacinia nisl. Mauris sagittis efficitur nisl. Ut tincidunt elementum rhoncus. Cras suscipit dolor sed est ultricies, quis dapibus neque suscipit. Etiam ac enim eu ligula bibendum blandit quis sit amet felis. Praesent mi nisi, luctus sit amet nunc ut, fermentum tempus purus. Suspendisse vel purus a nibh aliquam hendrerit. Aliquam sit amet tristique lorem. Sed elementum congue ante id mollis. Donec vitae pretium neque.",
+                "DEFAULT x'4c6f72656d20697073756d20646f6c6f722073697420616d65742c20636f6e73656374657475722061646970697363696e6720656c69742e204e616d207072657469756d2c20707572757320766974616520736f6c6c696369747564696e207661726975732c206e697369206c6563747573207665686963756c61206475692c207574206469676e697373696d2066656c697320646f6c6f7220626c616e646974206a7573746f2e20446f6e656320656c656966656e64206c656374757320757420666575676961742072686f6e6375732e20446f6e65632065726174206e6962682c2064617069627573206e6563206469616d2069642c206c6163696e6961206c6163696e6961206e69736c2e204d617572697320736167697474697320656666696369747572206e69736c2e2055742074696e636964756e7420656c656d656e74756d2072686f6e6375732e204372617320737573636970697420646f6c6f72207365642065737420756c747269636965732c20717569732064617069627573206e657175652073757363697069742e20457469616d20616320656e696d206575206c6967756c6120626962656e64756d20626c616e64697420717569732073697420616d65742066656c69732e205072616573656e74206d69206e6973692c206c75637475732073697420616d6574206e756e632075742c206665726d656e74756d2074656d7075732070757275732e2053757370656e64697373652076656c2070757275732061206e69626820616c697175616d2068656e6472657269742e20416c697175616d2073697420616d657420747269737469717565206c6f72656d2e2053656420656c656d656e74756d20636f6e67756520616e7465206964206d6f6c6c69732e20446f6e6563207669746165207072657469756d206e657175652e'",
+                id="b'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam pretium, purus vitae sollicitudin varius, nisi lectus vehicula dui, ut dignissim felis dolor blandit justo. Donec eleifend lectus ut feugiat rhoncus. Donec erat nibh, dapibus nec diam id, lacinia lacinia nisl. Mauris sagittis efficitur nisl. Ut tincidunt elementum rhoncus. Cras suscipit dolor sed est ultricies, quis dapibus neque suscipit. Etiam ac enim eu ligula bibendum blandit quis sit amet felis. Praesent mi nisi, luctus sit amet nunc ut, fermentum tempus purus. Suspendisse vel purus a nibh aliquam hendrerit. Aliquam sit amet tristique lorem. Sed elementum congue ante id mollis. Donec vitae pretium neque.'",
+            ),
+        ],
+    )
+    def test_translate_default_blob_bytes_from_mysql_to_sqlite(
+        self, column_default, sqlite_default_translation
+    ):
+        assert (
+            MySQLtoSQLite._translate_default_from_mysql_to_sqlite(
+                column_default, "BLOB"
+            )
+            == sqlite_default_translation
+        )
+
     @pytest.mark.parametrize(
         "collation, resulting_column_collation, column_type",
         [