🔊 more comprehensive error message regarding invalid column_type

Author: techouse

mysql_to_sqlite3/transporter.py

@@ -202,7 +202,7 @@ def _translate_type_from_mysql_to_sqlite(
         # This could be optimized even further, however is seems adequate.
         match: t.Optional[t.Match[str]] = cls._valid_column_type(_column_type)
         if not match:
-            raise ValueError("Invalid column_type!")
+            raise ValueError(f'"${_column_type}" is not a valid column_type!')
 
         data_type: str = match.group(0).upper()
 

tests/unit/mysql_to_sqlite3_test.py

@@ -26,7 +26,7 @@ def test_translate_type_from_mysql_to_sqlite_invalid_column_type(
         with pytest.raises(ValueError) as excinfo:
             mocker.patch.object(MySQLtoSQLite, "_valid_column_type", return_value=False)
             MySQLtoSQLite._translate_type_from_mysql_to_sqlite(column_type="text")
-        assert "Invalid column_type!" in str(excinfo.value)
+        assert "is not a valid column_type!" in str(excinfo.value)
 
     def test_translate_type_from_mysql_to_sqlite_all_valid_columns(self) -> None:
         for column_type in mysql_column_types + (