🐛 Fix SQLite convert_date converter

Author: techouse

.github/ISSUE_TEMPLATE/bug_report.md

@@ -30,3 +30,5 @@ This command is only available on v1.3.2 and greater. Otherwise, please provide
 
 **Additional context**
 Add any other context about the problem here.
+
+In case of errors please run the same command with `--debug`. This option is only available on v1.4.12 or greater.

mysql_to_sqlite3/__version__.py

@@ -2,7 +2,7 @@
 __title__ = "mysql-to-sqlite3"
 __description__ = "A simple Python tool to transfer data from MySQL to SQLite 3"
 __url__ = "https://github.com/techouse/mysql-to-sqlite3"
-__version__ = "1.4.11"
+__version__ = "1.4.12"
 __author__ = "Klemen Tusar"
 __author_email__ = "techouse@gmail.com"
 __license__ = "MIT"

mysql_to_sqlite3/cli.py

@@ -112,6 +112,7 @@
     "result sets, need to be combined or computed with each other.",
 )
 @click.option("-q", "--quiet", is_flag=True, help="Quiet. Display only errors.")
+@click.option("--debug", is_flag=True, help="Debug mode. Will throw exceptions.")
 @click.version_option(
     message=tabulate(info(), headers=["software", "version"], tablefmt="github")
 )
@@ -136,6 +137,7 @@ def cli(
     vacuum,
     use_buffered_cursors,
     quiet,
+    debug,
 ):
     """Transfer MySQL to SQLite using the provided CLI options."""
     try:
@@ -163,8 +165,12 @@ def cli(
         )
         converter.transfer()
     except KeyboardInterrupt:
+        if debug:
+            raise
         print("\nProcess interrupted. Exiting...")
         sys.exit(1)
     except Exception as err:  # pylint: disable=W0703
+        if debug:
+            raise
         print(err)
         sys.exit(1)

mysql_to_sqlite3/sqlite_utils.py

@@ -3,11 +3,18 @@
 from __future__ import division
 
 import sqlite3
-from datetime import timedelta
+from datetime import date, datetime, timedelta
 from decimal import Decimal
+from sys import version_info
 
+import six
 from pytimeparse.timeparse import timeparse
 
+if version_info.major == 3 and 4 <= version_info.minor <= 6:
+    from backports.datetime_fromisoformat import MonkeyPatch  # pylint: disable=E0401
+
+    MonkeyPatch.patch_fromisoformat()
+
 
 def adapt_decimal(value):
     """Convert decimal.Decimal to string."""
@@ -45,3 +52,20 @@ class CollatingSequences:
     BINARY = "BINARY"
     NOCASE = "NOCASE"
     RTRIM = "RTRIM"
+
+
+def convert_date(value):
+    """Handle SQLite date conversion."""
+    if six.PY3:
+        try:
+            return date.fromisoformat(value.decode())
+        except ValueError as err:
+            raise ValueError(  # pylint: disable=W0707
+                "DATE field contains {}".format(err)
+            )
+    try:
+        return datetime.strptime(value.decode(), "%Y-%m-%d").date()
+    except ValueError as err:
+        raise ValueError(  # pylint: disable=W0707
+            "DATE field contains Invalid isoformat string: {}".format(err)
+        )

mysql_to_sqlite3/transporter.py

@@ -20,6 +20,7 @@
     CollatingSequences,
     adapt_decimal,
     adapt_timedelta,
+    convert_date,
     convert_decimal,
     convert_timedelta,
     encode_data_for_sqlite,
@@ -102,6 +103,7 @@ def __init__(self, **kwargs):
         sqlite3.register_adapter(Decimal, adapt_decimal)
         sqlite3.register_converter("DECIMAL", convert_decimal)
         sqlite3.register_adapter(timedelta, adapt_timedelta)
+        sqlite3.register_converter("DATE", convert_date)
         sqlite3.register_converter("TIME", convert_timedelta)
 
         self._sqlite = sqlite3.connect(

requirements_dev.txt

@@ -23,4 +23,5 @@ tox
 tqdm>=4.35.0
 packaging>=20.3
 tabulate<0.8.6 ; python_version<"3.5"
-tabulate ; python_version>="3.5"
+tabulate ; python_version>="3.5"
+backports-datetime-fromisoformat>=1.0.0 ; python_version>="3.4" and python_version<="3.6"

setup.py

@@ -20,6 +20,7 @@
     "tqdm>=4.35.0",
     "tabulate<0.8.6 ; python_version<'3.5'",
     "tabulate ; python_version>='3.5'",
+    "backports-datetime-fromisoformat>=1.0.0 ; python_version>='3.4' and python_version<='3.6'",
 ]
 
 about = {}

tests/conftest.py

@@ -183,7 +183,7 @@ def mysql_credentials(pytestconfig):
     port = pytestconfig.getoption("mysql_port") or 3306
     if pytestconfig.getoption("use_docker"):
         while is_port_in_use(port, pytestconfig.getoption("mysql_host")):
-            if port >= 2 ** 16 - 1:
+            if port >= 2**16 - 1:
                 pytest.fail(
                     "No ports appear to be available on the host {}".format(
                         pytestconfig.getoption("mysql_host")
@@ -342,7 +342,6 @@ def mysql_database(tmpdir_factory, mysql_instance, mysql_credentials, faker):
         if database_exists(db.engine.url):
             drop_database(db.engine.url)
 
-
 else:
 
     @pytest.fixture(scope="session")

tests/factories.py

@@ -31,23 +31,23 @@ class MiscFactory(factory.Factory):
     class Meta:
         model = models.Misc
 
-    big_integer_field = factory.Faker("pyint", max_value=10 ** 9)
+    big_integer_field = factory.Faker("pyint", max_value=10**9)
     large_binary_field = factory.Faker("binary", length=1024 * 10)
     boolean_field = factory.Faker("boolean")
     char_field = factory.Faker("text", max_nb_chars=255)
     date_field = factory.Faker("date_this_decade")
     date_time_field = factory.Faker("date_time_this_century")
     decimal_field = factory.Faker("pydecimal", left_digits=8, right_digits=2)
     float_field = factory.Faker("pyfloat", left_digits=8, right_digits=4)
-    integer_field = factory.Faker("pyint", min_value=-(2 ** 31), max_value=2 ** 31 - 1)
+    integer_field = factory.Faker("pyint", min_value=-(2**31), max_value=2**31 - 1)
     if environ.get("LEGACY_DB", "0") == "0":
         json_field = factory.Faker("pydict")
     nchar_field = factory.Faker("text", max_nb_chars=255)
     numeric_field = factory.Faker("pyfloat", left_digits=8, right_digits=4)
     unicode_field = factory.Faker("text", max_nb_chars=255)
     real_field = factory.Faker("pyfloat", left_digits=8, right_digits=4)
     small_integer_field = factory.Faker(
-        "pyint", min_value=-(2 ** 15), max_value=2 ** 15 - 1
+        "pyint", min_value=-(2**15), max_value=2**15 - 1
     )
     string_field = factory.Faker("text", max_nb_chars=255)
     text_field = factory.Faker("text", max_nb_chars=1024)

tests/func/test_cli.py

@@ -162,9 +162,9 @@ def test_invalid_database_port(
         self, cli_runner, sqlite_database, mysql_database, mysql_credentials, faker
     ):
         if six.PY2:
-            port = choice(xrange(2, 2 ** 16 - 1))
+            port = choice(xrange(2, 2**16 - 1))
         else:
-            port = choice(range(2, 2 ** 16 - 1))
+            port = choice(range(2, 2**16 - 1))
         if port == mysql_credentials.port:
             port -= 1
         result = cli_runner.invoke(