BUG : a new reviewInput is reinstanciated for every sub-module in multi-module analysis.

Corrected by creating a ReviewHolder singleton.

Change-Id: Ie1624bbb73d556a3c198363c54ac7f50212fb79c

Author: mildis

pom.xml

@@ -6,7 +6,7 @@
 	<groupId>fr.techad</groupId>
 	<artifactId>sonar-gerrit-plugin</artifactId>
 	<packaging>sonar-plugin</packaging>
-	<version>2.0.0</version>
+	<version>2.0.1</version>
 
 	<name>Sonar Gerrit Plugin</name>
 	<description>Sonar will rate your gerrit patch set and comment on found alerts.</description>

src/main/java/fr/techad/sonar/GerritDecorator.java

@@ -49,7 +49,7 @@ public class GerritDecorator implements Decorator, PostJob {
     private GerritFacade gerritFacade;
     // Sonar's long name to Gerrit original file name map.
     private Map<String, String> gerritModifiedFiles;
-    private ReviewInput reviewInput = new ReviewInput();
+    private ReviewInput reviewInput = ReviewHolder.getReviewInput();
     private final ResourcePerspectives perspectives;
 
     public GerritDecorator(Settings settings, ResourcePerspectives perspectives) {
@@ -236,8 +236,12 @@ protected void processFileResource(@NotNull Resource resource, @NotNull Decorato
         commentIssues(issuable, comments);
         commentAlerts(context, comments);
         if (!comments.isEmpty()) {
+            LOG.debug("[GERRIT PLUGIN] comments not empty. Adding to reviewInput. {}", comments);
             reviewInput.addComments(gerritModifiedFiles.get(resource.getLongName()), comments);
         }
+        else {
+            LOG.debug("[GERRIT PLUGIN] comments empty. Nothing to add");
+        }
     }
 
     protected String substituteProperties(String originalMessage) {

src/main/java/fr/techad/sonar/ReviewHolder.java

@@ -0,0 +1,19 @@
+package fr.techad.sonar;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import fr.techad.sonar.gerrit.ReviewInput;
+
+public class ReviewHolder {
+	private static final Logger LOG = LoggerFactory.getLogger(ReviewHolder.class);
+	private static ReviewInput reviewInput = new ReviewInput();
+
+	private ReviewHolder() {
+	}
+
+	public static ReviewInput getReviewInput() {
+		LOG.debug("[GERRIT PLUGIN] Returning ReviewHolder.reviewInput");
+		return reviewInput;
+	}
+}