Fix knative-extensions#626 Do no affect Redis Config nor TLS Config if they are nil

Author: tdeverdiere

pkg/sink/reconciler/streamsink/streamsink.go

@@ -95,7 +95,8 @@ func (r *Reconciler) updateTLSSecret(ctx context.Context, secret *corev1.Secret)
 	tlsSecret, err := GetTLSSecret(secret.Data)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Error reading TLS configuration", zap.Error(err))
+	} else {
+		// For now just override the previous config.
+		r.tlsCert = tlsSecret.TLSCertificate
 	}
-	// For now just override the previous config.
-	r.tlsCert = tlsSecret.TLSCertificate
 }

pkg/source/reconciler/streamsource/streamsource.go

@@ -127,16 +127,18 @@ func (r *Reconciler) updateRedisConfig(ctx context.Context, configMap *corev1.Co
 	redisConfig, err := GetRedisConfig(configMap.Data)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Error reading Redis configuration", zap.Error(err))
+	} else {
+		// For now just override the previous config.
+		r.numConsumers = redisConfig.NumConsumers
 	}
-	// For now just override the previous config.
-	r.numConsumers = redisConfig.NumConsumers
 }
 
 func (r *Reconciler) updateTLSSecret(ctx context.Context, secret *corev1.Secret) {
 	tlsSecret, err := GetTLSSecret(secret.Data)
 	if err != nil {
 		logging.FromContext(ctx).Errorw("Error reading TLS configuration", zap.Error(err))
+	} else {
+		// For now just override the previous config.
+		r.tlsCert = tlsSecret.TLSCertificate
 	}
-	// For now just override the previous config.
-	r.tlsCert = tlsSecret.TLSCertificate
 }