Skip to content

Commit 4cdaf51

Browse files
committed
Remove some assumes from slice iterators that don't do anything
1 parent c029b14 commit 4cdaf51

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

core/src/slice/iter/macros.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,10 @@ macro_rules! iterator {
124124
fn next(&mut self) -> Option<$elem> {
125125
// could be implemented with slices, but this avoids bounds checks
126126

127-
// SAFETY: `assume` calls are safe since a slice's start pointer
128-
// must be non-null, and slices over non-ZSTs must also have a
129-
// non-null end pointer. The call to `next_unchecked!` is safe
130-
// since we check if the iterator is empty first.
127+
// SAFETY: `assume` call is safe because slices over non-ZSTs must
128+
// have a non-null end pointer. The call to `next_unchecked!` is
129+
// safe since we check if the iterator is empty first.
131130
unsafe {
132-
assume(!self.ptr.as_ptr().is_null());
133131
if !<T>::IS_ZST {
134132
assume(!self.end.is_null());
135133
}
@@ -339,12 +337,10 @@ macro_rules! iterator {
339337
fn next_back(&mut self) -> Option<$elem> {
340338
// could be implemented with slices, but this avoids bounds checks
341339

342-
// SAFETY: `assume` calls are safe since a slice's start pointer must be non-null,
343-
// and slices over non-ZSTs must also have a non-null end pointer.
344-
// The call to `next_back_unchecked!` is safe since we check if the iterator is
345-
// empty first.
340+
// SAFETY: `assume` call is safe because slices over non-ZSTs must
341+
// have a non-null end pointer. The call to `next_back_unchecked!`
342+
// is safe since we check if the iterator is empty first.
346343
unsafe {
347-
assume(!self.ptr.as_ptr().is_null());
348344
if !<T>::IS_ZST {
349345
assume(!self.end.is_null());
350346
}

0 commit comments

Comments
 (0)