attempt to fix #298, and add logging for these sync response paths

Author: tayloraswift

Sources/GitHubAPI/GitHub.Repo.swift

@@ -139,6 +139,9 @@ extension GitHub.Repo:JSONObjectDecodable
     public
     init(json:JSON.ObjectDecoder<CodingKey>) throws
     {
+        //  Note: GitHub often returns explicit `null` values for fields that are missing.
+        //  This means we need to be careful when mapping optional fields, particularly through
+        //  the use `as:`.
         self.init(id: try json[.id].decode(),
             owner: try json[.owner].decode(),
             name: try json[.name].decode(),
@@ -152,10 +155,20 @@ extension GitHub.Repo:JSONObjectDecodable
             archived: try json[.archived].decode(),
             disabled: try json[.disabled].decode(),
             fork: try json[.fork].decode(),
-            homepage: try json[.homepage]?.decode(as: String.self) { $0.isEmpty ? nil : $0 },
-            about: try json[.about]?.decode(as: String.self) { $0.isEmpty ? nil : $0 },
+            homepage: try json[.homepage]?.decode(),
+            about: try json[.about]?.decode(),
             created: try json[.created].decode(),
             updated: try json[.updated].decode(),
             pushed: try json[.pushed].decode())
+
+        //  String field normalization.
+        if  case true? = self.homepage?.isEmpty
+        {
+            self.homepage = nil
+        }
+        if  case true? = self.about?.isEmpty
+        {
+            self.about = nil
+        }
     }
 }

Sources/HTTP/HTTP.Resource.Content.Body.swift

@@ -18,6 +18,19 @@ extension HTTP.Resource.Content.Body
         .binary(bytes[...])
     }
 }
+extension HTTP.Resource.Content.Body:CustomStringConvertible
+{
+    @inlinable public
+    var description:String
+    {
+        switch self
+        {
+        case .binary(let self): .init(decoding: self, as: Unicode.UTF8.self)
+        case .buffer(let self): .init(decoding: self.readableBytesView, as: Unicode.UTF8.self)
+        case .string(let self): self
+        }
+    }
+}
 extension HTTP.Resource.Content.Body
 {
     /// The size of the content to be transferred, in bytes. Unlike ``length``, this property

Sources/UnidocServer/Requests/Unidoc.Router.swift

@@ -723,7 +723,9 @@ extension Unidoc.Router
             }
             catch let error
             {
-                return .sync(error: "Rejected webhook event: \(error)")
+                //  This is considered a server error, so we want to flag it as such for the
+                //  logging system to pick up.
+                return .sync(error: "Rejected webhook event: \(error)", status: 500)
             }
 
         default:

Sources/UnidocServer/Server/Unidoc.Server.swift

@@ -193,10 +193,13 @@ extension Unidoc.Server
             return await self.submit(update: procedural)
 
         case .sync(let response):
+            self.logger?.log(request: request.incoming, with: response, time: .zero)
             return response
 
         case .syncHTML(let renderable):
-            return renderable.response(format: self.format)
+            let response:HTTP.ServerResponse = renderable.response(format: self.format)
+            self.logger?.log(request: request.incoming, with: response, time: .zero)
+            return response
 
         case .syncLoad(let request):
             guard case .development(let cache, _) = self.options.mode