move the phylum types from Unidoc to Symbols, and liberate SymbolGraphs and SymbolGraphParts from their Unidoc dependencies

Author: tayloraswift

Package.swift

@@ -159,6 +159,7 @@ let package:Package = .init(
             [
                 .target(name: "Codelinks"),
                 .target(name: "Symbols"),
+                //  This dependency is present for (questionable?) performance reasons.
                 .target(name: "Unidoc"),
             ]),
 
@@ -406,7 +407,6 @@ let package:Package = .init(
                 .target(name: "MarkdownPluginSwift"),
                 .target(name: "Signatures"),
                 .target(name: "Symbols"),
-                .target(name: "Unidoc"),
             ]),
 
         .target(name: "SymbolGraphs", dependencies:
@@ -416,7 +416,6 @@ let package:Package = .init(
                 .target(name: "SHA1"),
                 .target(name: "Signatures"),
                 .target(name: "Symbols"),
-                .target(name: "Unidoc"),
 
                 .product(name: "BSON", package: "swift-mongodb"),
             ],

Sources/CodelinkResolution/Codelink.Filter (ext).swift

@@ -1,13 +1,13 @@
 import Codelinks
-import Unidoc
+import Symbols
 
 extension Codelink.Filter
 {
     static
-    func ~= (self:Self, phylum:Unidoc.Decl?) -> Bool
+    func ~= (self:Self, phylum:Phylum.Decl?) -> Bool
     {
         guard
-        let phylum:Unidoc.Decl
+        let phylum:Phylum.Decl
         else
         {
             return false

Sources/CodelinkResolution/Codelink.Suffix.Legacy.Filter (ext).swift

@@ -1,13 +1,13 @@
 import Codelinks
-import Unidoc
+import Symbols
 
 extension Codelink.Suffix.Legacy.Filter
 {
     static
-    func ~= (self:Self, phylum:Unidoc.Decl?) -> Bool
+    func ~= (self:Self, phylum:Phylum.Decl?) -> Bool
     {
         guard
-        let phylum:Unidoc.Decl
+        let phylum:Phylum.Decl
         else
         {
             return false

Sources/CodelinkResolution/CodelinkResolver.Overload.swift

@@ -1,5 +1,5 @@
 import FNV1
-import Unidoc
+import Symbols
 
 extension CodelinkResolver
 {
@@ -11,12 +11,12 @@ extension CodelinkResolver
 
         /// The phylum of the target, if it is a declaration. If a module, this is nil.
         public
-        let phylum:Unidoc.Decl?
+        let phylum:Phylum.Decl?
         public
         let hash:FNV24
 
         @inlinable public
-        init(target:Target, phylum:Unidoc.Decl?, hash:FNV24)
+        init(target:Target, phylum:Phylum.Decl?, hash:FNV24)
         {
             self.target = target
             self.phylum = phylum

Sources/Codelinks/V3/CodelinkV3.Filter.swift

@@ -23,7 +23,7 @@ extension CodelinkV3.Filter
     public
     init?(suffix:Substring)
     {
-        //  Very similar to the `Unidoc.Phylum` type, except no extensions.
+        //  Very similar to the `Phylum` type, except no extensions.
         switch suffix
         {
         case "swift.associatedtype":    self = .associatedtype

Sources/SymbolGraphCompiler/Compiler/Compiler.VertexError.swift

@@ -13,10 +13,10 @@ extension Compiler
         public
         let symbol:Symbol.USR
         public
-        let phylum:Unidoc.Phylum
+        let phylum:Phylum
 
         public
-        init(underlying:any Error, symbol:Symbol.USR, phylum:Unidoc.Phylum)
+        init(underlying:any Error, symbol:Symbol.USR, phylum:Phylum)
         {
             self.underlying = underlying
             self.symbol = symbol

Sources/SymbolGraphCompiler/Declarations/Compiler.Decl.swift

@@ -22,7 +22,7 @@ extension Compiler
         let location:SourceLocation<Symbol.File>?
 
         public
-        let phylum:Unidoc.Decl
+        let phylum:Phylum.Decl
         public
         let path:UnqualifiedPath
 
@@ -53,7 +53,7 @@ extension Compiler
         public internal(set)
         var origin:Symbol.Decl?
         public internal(set)
-        var kinks:Unidoc.Decl.Kinks
+        var kinks:Phylum.Decl.Kinks
 
         public private(set)
         var comment:Doccomment?
@@ -63,7 +63,7 @@ extension Compiler
         init(_ id:Symbol.Decl,
             signature:Signature<Symbol.Decl>,
             location:SourceLocation<Symbol.File>?,
-            phylum:Unidoc.Decl,
+            phylum:Phylum.Decl,
             path:UnqualifiedPath)
         {
             self.id = id

Sources/SymbolGraphCompiler/Declarations/Compiler.DeclObject.swift

@@ -49,7 +49,7 @@ extension Compiler.DeclObject
         self.value.id
     }
 
-    var kinks:Unidoc.Decl.Kinks
+    var kinks:Phylum.Decl.Kinks
     {
         _read   { yield  self.value.kinks }
         _modify { yield &self.value.kinks }

Sources/SymbolGraphCompiler/Declarations/Compiler.Nomination.swift

@@ -9,9 +9,9 @@ extension Compiler
         @usableFromInline internal
         let name:String
         @usableFromInline internal
-        let phylum:Unidoc.Decl
+        let phylum:Phylum.Decl
 
-        init(_ name:String, phylum:Unidoc.Decl)
+        init(_ name:String, phylum:Phylum.Decl)
         {
             self.name = name
             self.phylum = phylum

Sources/SymbolGraphCompiler/Declarations/Compiler.Nominations.swift

@@ -20,7 +20,7 @@ extension Compiler
 extension Compiler.Nominations
 {
     @inlinable public
-    subscript(feature scalar:Symbol.Decl) -> (name:String, phylum:Unidoc.Decl)?
+    subscript(feature scalar:Symbol.Decl) -> (name:String, phylum:Phylum.Decl)?
     {
         self.nominations[scalar].map { ($0.name, $0.phylum) }
     }