factor nio-dependent parts of GitHubIntegration into GitHubClient

Author: tayloraswift

Package.swift

@@ -123,10 +123,15 @@ let package:Package = .init(
 
         .target(name: "FNV1"),
 
+        .target(name: "GitHubClient", dependencies:
+            [
+                .target(name: "GitHubIntegration"),
+                .target(name: "HTTPClient"),
+            ]),
+
         .target(name: "GitHubIntegration", dependencies:
             [
                 .target(name: "JSON"),
-                .target(name: "HTTPClient"),
             ]),
 
         .target(name: "HTML", dependencies:
@@ -360,6 +365,7 @@ let package:Package = .init(
 
         .target(name: "UnidocDatabase", dependencies:
             [
+                .target(name: "GitHubIntegration"),
                 .target(name: "UnidocAnalysis"),
                 .target(name: "UnidocLinker"),
                 .product(name: "MongoDB", package: "swift-mongodb"),
@@ -427,6 +433,7 @@ let package:Package = .init(
 
         .executableTarget(name: "UnidocServer", dependencies:
             [
+                .target(name: "GitHubClient"),
                 .target(name: "Multiparts"),
                 .target(name: "System"),
                 .target(name: "UnidocPages"),

Sources/GitHubIntegration/GitHubApplication.Client.swift renamed to Sources/GitHubClient/GitHubApplication.Client.swift

@@ -1,3 +1,4 @@
+import GitHubIntegration
 import HTTPClient
 import JSON
 import NIOCore
@@ -10,6 +11,7 @@ extension GitHubApplication
     {
         private
         let http2:ClientInterface
+
         public
         let app:GitHubApplication
 
@@ -21,6 +23,14 @@ extension GitHubApplication
         }
     }
 }
+extension GitHubApplication.Client:Identifiable
+{
+    @inlinable public
+    var id:String { self.app.client }
+
+    @inlinable public
+    var secret:String { self.app.secret }
+}
 extension GitHubApplication.Client
 {
     public
@@ -33,7 +43,7 @@ extension GitHubApplication.Client
             ":authority": "github.com",
             ":path": """
                 /login/oauth/access_token?\
-                client_id=\(self.app.id)&client_secret=\(self.app.secret)&code=\(code)
+                client_id=\(self.id)&client_secret=\(self.secret)&code=\(code)
                 """,
 
             "accept": "application/vnd.github+json",

Sources/GitHubClient/exports.swift

@@ -0,0 +1 @@
+@_exported import struct GitHubIntegration.GitHubApplication

Sources/GitHubIntegration/GitHubApplication.swift

@@ -1,20 +1,19 @@
-import HTTPClient
-import JSON
-import NIOCore
-import NIOHPACK
-
 @frozen public
 struct GitHubApplication:Identifiable, Equatable, Hashable, Sendable
 {
     public
-    let secret:String
+    let id:Int
+
     public
-    let id:String
+    let client:String
+    public
+    let secret:String
 
     @inlinable public
-    init(_ id:String, secret:String = "3a892428d6381dbcfdafab55ad2fbec6d4847430")
+    init(_ id:Int, client:String, secret:String)
     {
         self.id = id
+        self.client = client
         self.secret = secret
     }
 }

Sources/UnidocDatabase/Users/User.swift

@@ -0,0 +1,6 @@
+@frozen public
+struct User
+{
+    public
+    let id:Int
+}

Sources/UnidocPages/Templates/Site.Login.swift

@@ -55,7 +55,12 @@ extension Site.Login:AdministrativePage
         }
             content:
         {
-            $0[.input] { $0.type = "hidden" ; $0.name = "client_id" ; $0.value = self.app.id }
+            $0[.input]
+            {
+                $0.type = "hidden"
+                $0.name = "client_id"
+                $0.value = self.app.client
+            }
             $0[.input] { $0.type = "hidden" ; $0.name = "scope" ; $0.value = "repo" }
 
             $0[.input] { $0.type = "submit" ; $0.value = "Log in with GitHub" }

Sources/UnidocServer/Server/Server.swift

@@ -1,4 +1,4 @@
-import GitHubIntegration
+import GitHubClient
 import HTTPClient
 import HTTPServer
 import MongoDB
@@ -57,7 +57,8 @@ extension Server
                 http2: .init(threads: threads,
                     niossl: niossl,
                     remote: "github.com"),
-                app: .init("Iv1.dba609d35c70bf57",
+                app: .init(383005,
+                    client: "Iv1.dba609d35c70bf57",
                     secret: secret))
         }
         else