replace installation ID with boolean private indicator

Author: tayloraswift

Sources/UnidocDB/Packages/Unidoc.PackageRepo (ext).swift

@@ -12,8 +12,7 @@ extension Unidoc.PackageRepo
 {
     @inlinable public static
     func github(_ repo:GitHub.Repo,
-        crawled:UnixMillisecond,
-        installation:Int32? = nil) throws -> Self
+        crawled:UnixMillisecond) throws -> Self
     {
         /// We clip this to Midnights because we use this as a shard key, and also because
         /// Midnights are Swifty.
@@ -46,6 +45,7 @@ extension Unidoc.PackageRepo
             created: .init(created),
             updated: updated,
             license: repo.license.map { .init(spdx: $0.id, name: $0.name) },
+            private: repo.visibility == .private,
             topics: repo.topics,
             master: repo.master,
             origin: .github(.init(
@@ -59,8 +59,7 @@ extension Unidoc.PackageRepo
                 size: repo.size,
                 archived: repo.archived,
                 disabled: repo.disabled,
-                fork: repo.fork,
-                installation: installation)),
+                fork: repo.fork)),
             forks: repo.forks,
             stars: repo.stars)
     }

Sources/UnidocRecords/Origins/Unidoc.GitHubOrigin.swift

@@ -38,10 +38,6 @@ extension Unidoc
         public
         var fork:Bool
 
-        /// A GitHub App installation, currently only set for private repositories.
-        public
-        var installation:Int32?
-
         @inlinable public
         init(id:Int32,
             owner:String,
@@ -53,8 +49,7 @@ extension Unidoc
             size:Int,
             archived:Bool,
             disabled:Bool,
-            fork:Bool,
-            installation:Int32?)
+            fork:Bool)
         {
             self.id = id
             self.pushed = pushed
@@ -67,7 +62,6 @@ extension Unidoc
             self.archived = archived
             self.disabled = disabled
             self.fork = fork
-            self.installation = installation
         }
     }
 }
@@ -107,6 +101,8 @@ extension Unidoc.GitHubOrigin
         case archived = "X"
         case disabled = "D"
         case fork = "K"
+
+        @available(*, unavailable)
         case installation = "L"
     }
 }
@@ -129,7 +125,6 @@ extension Unidoc.GitHubOrigin:BSONDocumentEncodable
         bson[.archived] = self.archived
         bson[.disabled] = self.disabled
         bson[.fork] = self.fork
-        bson[.installation] = self.installation
     }
 }
 extension Unidoc.GitHubOrigin:BSONDocumentDecodable
@@ -147,7 +142,6 @@ extension Unidoc.GitHubOrigin:BSONDocumentDecodable
             size: try bson[.size].decode(),
             archived: try bson[.archived].decode(),
             disabled: try bson[.disabled].decode(),
-            fork: try bson[.fork].decode(),
-            installation: try bson[.installation]?.decode())
+            fork: try bson[.fork].decode())
     }
 }

Sources/UnidocRecords/Packages/Unidoc.PackageRepo.swift

@@ -33,6 +33,12 @@ extension Unidoc
         /// The repo’s license. All software repos have the concept of a license.
         public
         var license:PackageLicense?
+
+        /// Indicates if the repo is private, and therefore cannot be cloned without
+        /// authentication.
+        public
+        var `private`:Bool
+
         /// The repo’s topic memberships. Both GitHub and GitLab have topics.
         public
         var topics:[String]
@@ -57,6 +63,7 @@ extension Unidoc
             created:UnixMillisecond,
             updated:UnixMillisecond,
             license:PackageLicense?,
+            private:Bool,
             topics:[String],
             master:String?,
             origin:PackageOrigin,
@@ -69,6 +76,7 @@ extension Unidoc
             self.created = created
             self.updated = updated
             self.license = license
+            self.private = `private`
             self.topics = topics
             self.master = master
             self.origin = origin
@@ -95,6 +103,7 @@ extension Unidoc.PackageRepo
         case updated = "U"
 
         case license = "L"
+        case `private` = "X"
         case topics = "T"
         case master = "M"
 
@@ -115,6 +124,7 @@ extension Unidoc.PackageRepo:BSONDocumentEncodable
         bson[.updated] = self.updated
 
         bson[.license] = self.license
+        bson[.private] = self.private
         bson[.topics] = self.topics.isEmpty ? nil : self.topics
         bson[.master] = self.master
 
@@ -140,6 +150,8 @@ extension Unidoc.PackageRepo:BSONDocumentDecodable
             created: try bson[.created].decode(),
             updated: try bson[.updated].decode(),
             license: try bson[.license]?.decode(),
+            //  TODO: deoptionalize
+            private: try bson[.private]?.decode() ?? false,
             topics: try bson[.topics]?.decode() ?? [],
             master: try bson[.master]?.decode(),
             origin: origin,

Sources/UnidocServer/Operations/Interactions/Unidoc.WebhookOperation.swift

@@ -132,9 +132,7 @@ extension Unidoc.WebhookOperation
         in db:Unidoc.Database,
         at time:UnixMillisecond) async throws -> HTTP.ServerResponse
     {
-        let repo:Unidoc.PackageRepo = try .github(event.repo,
-            crawled: time,
-            installation: event.repo.visibility == .private ? event.installation : nil)
+        let repo:Unidoc.PackageRepo = try .github(event.repo, crawled: time)
 
         let indexEligible:Bool
         let repoWebhook:String

Sources/UnidocServer/Operations/Procedures/Unidoc.BuilderUploadOperation.swift

@@ -64,8 +64,7 @@ extension Unidoc.BuilderUploadOperation:Unidoc.BlockingOperation
                 /// hazard, because the logs contain secrets, and the log URLs are easily
                 /// predicted. For now, we just discard the logs for private repositories.
                 let _logsIncluded:Bool
-                if  case .github(let origin)? = _metadata?.repo?.origin,
-                    case _? = origin.installation
+                if  case true? = _metadata?.repo?.private
                 {
                     _logsIncluded = false
                 }