don’t update stats from logged-in users

Author: tayloraswift

Sources/UnidocPages/Tours/ServerTour.Stats.ByType.swift

@@ -6,28 +6,24 @@ extension ServerTour.Stats
         public
         var siteMap:Int
         public
-        var restricted:Int
-        public
         var query:Int
         public
         var other:Int
 
         @inlinable public
         init(siteMap:Int = 0,
-            restricted:Int = 0,
             query:Int = 0,
             other:Int = 0)
         {
             self.siteMap = siteMap
-            self.restricted = restricted
             self.query = query
             self.other = other
         }
     }
 }
 extension ServerTour.Stats.ByType
 {
-    /// The total count, except for the ``restricted`` type.
+    /// The total count.
     @inlinable public
     var total:Int
     {

Sources/UnidocServer/RestrictedOperation.swift

@@ -11,13 +11,6 @@ protocol RestrictedOperation:InteractiveOperation
     func load(from state:Server.State) async throws -> ServerResponse?
 }
 extension RestrictedOperation
-{
-    var statisticalType:WritableKeyPath<ServerTour.Stats.ByType, Int>
-    {
-        \.restricted
-    }
-}
-extension RestrictedOperation
 {
     static
     func admit(_ role:Account.Role) -> Bool

Sources/UnidocServer/Server/Server.State.swift

@@ -50,16 +50,17 @@ extension Server.State
                         content: .string("not found"),
                         type: .text(.plain, charset: .utf8)))
 
-                self.tour.stats.requests[keyPath: type] += 1
+                //  Don’t increment stats from administrators,
+                //  they will really skew the results.
+                if  case nil = request.cookies.session
+                {
+                    self.tour.stats.requests[keyPath: type] += 1
+                    self.tour.stats.bytes[keyPath: type] += response.size
 
-                let status:WritableKeyPath<ServerTour.Stats.ByStatus, Int> =
-                    response.statisticalStatus
+                    let status:WritableKeyPath<ServerTour.Stats.ByStatus, Int> =
+                        response.statisticalStatus
 
-                //  Don’t count visits to the admin tools.
-                if  type != \.restricted
-                {
                     self.tour.stats.responses[keyPath: status] += 1
-                    self.tour.stats.bytes[keyPath: type] += response.size
                 }
 
                 request.promise.succeed(response)