we cannot reliably get the number of GitHub watchers, or keep the count sufficiently fresh, so let’s just remove it

Author: tayloraswift

Sources/UnidocDB/Packages/Unidoc.GitHubRepoMetadataError.swift

@@ -5,8 +5,6 @@ extension Unidoc
     @frozen @usableFromInline
     enum GitHubRepoMetadataError:Equatable, Error
     {
-        case watchers
-
         case created(String)
         case updated(String)
         case pushed(String)
@@ -19,7 +17,6 @@ extension Unidoc.GitHubRepoMetadataError:CustomStringConvertible
     {
         switch self
         {
-        case .watchers:             "repository metadata is missing field 'watchers'"
         case .created(let string):  "invalid timestamp '\(string)' for field 'created'"
         case .updated(let string):  "invalid timestamp '\(string)' for field 'updated'"
         case .pushed(let string):   "invalid timestamp '\(string)' for field 'pushed'"

Sources/UnidocDB/Packages/Unidoc.PackageRepo (ext).swift

@@ -13,13 +13,6 @@ extension Unidoc.PackageRepo
     @inlinable public static
     func github(_ repo:GitHub.Repo, crawled:BSON.Millisecond) throws -> Self
     {
-        guard
-        let watchers:Int = repo.watchers
-        else
-        {
-            throw Unidoc.GitHubRepoMetadataError.watchers
-        }
-
         guard
         let created:Timestamp.Components = .init(iso8601: repo.created),
         let created:UnixInstant = .init(utc: .date(created))
@@ -60,7 +53,6 @@ extension Unidoc.PackageRepo
                 name: repo.name,
                 homepage: repo.homepage,
                 about: repo.about,
-                watchers: watchers,
                 size: repo.size,
                 archived: repo.archived,
                 disabled: repo.disabled,

Sources/UnidocRecords/Origins/Unidoc.GitHubOrigin.swift

@@ -22,8 +22,6 @@ extension Unidoc
         public
         var about:String?
 
-        public
-        var watchers:Int
         public
         var size:Int
 
@@ -41,7 +39,6 @@ extension Unidoc
             name:String,
             homepage:String?,
             about:String?,
-            watchers:Int,
             size:Int,
             archived:Bool,
             disabled:Bool,
@@ -53,7 +50,6 @@ extension Unidoc
             self.name = name
             self.homepage = homepage
             self.about = about
-            self.watchers = watchers
             self.size = size
             self.archived = archived
             self.disabled = disabled
@@ -82,7 +78,9 @@ extension Unidoc.GitHubOrigin
         case homepage = "H"
         case about = "A"
 
+        @available(*, unavailable)
         case watchers = "W"
+
         case size = "S"
 
         case archived = "X"
@@ -103,7 +101,6 @@ extension Unidoc.GitHubOrigin:BSONDocumentEncodable
         bson[.homepage] = self.homepage
         bson[.about] = self.about
 
-        bson[.watchers] = self.watchers
         bson[.size] = self.size
 
         bson[.archived] = self.archived
@@ -122,7 +119,6 @@ extension Unidoc.GitHubOrigin:BSONDocumentDecodable
             name: try bson[.name].decode(),
             homepage: try bson[.homepage]?.decode(),
             about: try bson[.about]?.decode(),
-            watchers: try bson[.watchers].decode(),
             size: try bson[.size].decode(),
             archived: try bson[.archived].decode(),
             disabled: try bson[.disabled].decode(),

Sources/UnidocServer/Operations/Interactions/Unidoc.PackageWebhookOperation.swift

@@ -83,10 +83,6 @@ extension Unidoc.PackageWebhookOperation:Unidoc.PublicOperation
         }
 
         //  TODO: see if we can also perform a package metadata update
-        if  case .github(let origin)? = package.repo?.origin
-        {
-            event.repo.watchers = origin.watchers
-        }
 
         let (_, new):(Unidoc.EditionMetadata, new:Bool) = try await server.db.unidoc.index(
             package: package.id,

Sources/UnidocUI/Endpoints/Tags/Unidoc.VersionsPage.swift

@@ -155,8 +155,8 @@ extension Unidoc.VersionsPage
                         }
                     }
 
-                    $0[.dt] = "Watchers"
-                    $0[.dd] = "\(origin.watchers)"
+                    $0[.dt] = "Stars"
+                    $0[.dd] = "\(repo.stars)"
 
                     $0[.dt] = "Forks"
                     $0[.dd] = "\(repo.forks)"