always order unconstrained extensions before constrained ones

tayloraswift · tayloraswift · commit 082899eb96b7 · 2023-08-29T00:34:31.000Z
diff --git a/Sources/UnidocPages/Groups/Inliner.Groups.Genericness.swift b/Sources/UnidocPages/Groups/Inliner.Groups.Genericness.swift
@@ -2,7 +2,11 @@ extension Inliner.Groups
 {
     enum Genericness:Equatable, Hashable, Comparable, Sendable
     {
-        case generic
-        case concrete
+        /// No generic constraints.
+        case unconstrained
+        /// At least one generic constraint, but not enough to fully concretize the extension.
+        case constrained
+        /// Enough generic constraints to fully concretize the extension.
+        case concretized
     }
 }
diff --git a/Sources/UnidocPages/Groups/Inliner.Groups.swift b/Sources/UnidocPages/Groups/Inliner.Groups.swift
@@ -77,8 +77,10 @@ extension Inliner.Groups
                     .third($0.package)
                 } ?? .first
 
-                let genericness:Genericness =
-                    generics.count(substituting: group.conditions) == 0 ? .generic : .concrete
+                let genericness:Genericness = group.conditions.isEmpty ?
+                    .unconstrained : generics.count(substituting: group.conditions) > 0 ?
+                    .constrained :
+                    .concretized
 
                 extensions.append((group, partisanship, genericness))
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,11 @@ extension Inliner.Groups`
`2`	`2`	`{`
`3`	`3`	`enum Genericness:Equatable, Hashable, Comparable, Sendable`
`4`	`4`	`{`
`5`		`- case generic`
`6`		`- case concrete`
	`5`	`+ /// No generic constraints.`
	`6`	`+ case unconstrained`
	`7`	`+ /// At least one generic constraint, but not enough to fully concretize the extension.`
	`8`	`+ case constrained`
	`9`	`+ /// Enough generic constraints to fully concretize the extension.`
	`10`	`+ case concretized`
`7`	`11`	`}`
`8`	`12`	`}`