Merge pull request #83 from espressif/master

Fixes softAPConfig() return

Author: Jason2866

docs/source/installing.rst

@@ -16,7 +16,7 @@ Installing using Boards Manager
 This is the preferred and easiest way to install Arduino-ESP32.
 
 .. note::
-   Currently, the support for new chips (ESP32-S2 and ESP32-C3) is in the development release. Consider installing the development release if you need to test the new supported SoC in beta.
+   For overview of SoC's support, take a look on `Supported Soc's table <https://docs.espressif.com/projects/arduino-esp32/en/latest/getting_started.html#supported-soc-s>`_ where you can find if the particular chip is under stable or development release.
 
 - Stable release link::
 

libraries/HTTPClient/src/HTTPClient.cpp

@@ -1543,6 +1543,10 @@ void HTTPClient::clearAllCookies()
 
 void HTTPClient::setCookie(String date, String headerValue)
 {
+    if (!_cookieJar)
+    {
+        return;
+    }
     #define HTTP_TIME_PATTERN "%a, %d %b %Y %H:%M:%S"
 
     Cookie cookie;
@@ -1574,7 +1578,7 @@ void HTTPClient::setCookie(String date, String headerValue)
             value = headerValue.substring(pos1, pos2);
         else
             value = headerValue.substring(pos1);
-    
+
         strptime(value.c_str(), HTTP_TIME_PATTERN, &tm);
         cookie.expires.date = mktime(&tm);
         cookie.expires.valid = true;
@@ -1589,7 +1593,7 @@ void HTTPClient::setCookie(String date, String headerValue)
             value = headerValue.substring(pos1, pos2);
         else
             value = headerValue.substring(pos1);
-    
+
         cookie.max_age.duration = value.toInt();
         cookie.max_age.valid = true;
     }
@@ -1639,10 +1643,10 @@ void HTTPClient::setCookie(String date, String headerValue)
     // overwrite or delete cookie in/from cookie jar
     time_t now_local = time(NULL);
     time_t now_gmt = mktime(gmtime(&now_local));
-    
+
     bool found = false;
 
-	for (auto c = _cookieJar->begin(); c != _cookieJar->end(); ++c) {
+    for (auto c = _cookieJar->begin(); c != _cookieJar->end(); ++c) {
         if (c->domain == cookie.domain && c->name == cookie.name) {
             // when evaluating, max-age takes precedence over expires if both are defined
             if ((cookie.max_age.valid && ((cookie.date + cookie.max_age.duration) < now_gmt)) || cookie.max_age.duration <= 0
@@ -1670,6 +1674,10 @@ bool HTTPClient::generateCookieString(String *cookieString)
     *cookieString = "";
     bool found = false;
 
+    if (!_cookieJar)
+    {
+        return false;
+    }
  	for (auto c = _cookieJar->begin(); c != _cookieJar->end(); ++c) {
         if ((c->max_age.valid && ((c->date + c->max_age.duration) < now_gmt)) || (!c->max_age.valid && c->expires.valid && c->expires.date < now_gmt)) {
             _cookieJar->erase(c);
@@ -1682,5 +1690,6 @@ bool HTTPClient::generateCookieString(String *cookieString)
             found = true;
         }
     }
+    
     return found;
 }

libraries/WiFi/src/WiFiAP.cpp

@@ -205,7 +205,23 @@ bool WiFiAPClass::softAPConfig(IPAddress local_ip, IPAddress gateway, IPAddress
     }
 
     err = set_esp_interface_ip(ESP_IF_WIFI_AP, local_ip, gateway, subnet);
-    return err == ESP_OK;
+
+    // testing effectiveness of the operation beyond internal DHCP Client process
+	esp_netif_ip_info_t ip;
+    if(esp_netif_get_ip_info(get_esp_interface_netif(ESP_IF_WIFI_AP), &ip) != ESP_OK){
+    	log_e("Netif Get IP Failed!");
+    	return false;
+    }
+    bool ip_ok = IPAddress(ip.ip.addr) == local_ip;
+    bool gw_ok = IPAddress(ip.gw.addr) == gateway;
+    bool mk_ok = IPAddress(ip.netmask.addr) == subnet;
+
+    if (ip_ok && gw_ok && mk_ok) {
+        return true;
+    } else {
+        log_e("Failed setting: %s %s %s", ip_ok ? "" : "Static IP", gw_ok ? "" : "- Gateway", mk_ok ? "" : "- Netmask"); 
+        return false;
+    }
 }