Skip to content

Commit 6527b77

Browse files
chore: remove subtle feature (#6185)
Description --- Removes the `core_hint_black_box` feature from `subtle`. Motivation and Context --- We currently use the `core_hint_black_box` feature from `subtle`, which uses a particular [optimization barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L245-L250). However, the standard library [documentation](https://doc.rust-lang.org/std/hint/fn.black_box.html) cautions against the use of `std::hint::black_box` for cryptographic use. This has led `subtle` to [remove it](dalek-cryptography/subtle#107) in an upcoming release, at which point the feature will do nothing. This PR takes the proactive step of removing the feature. There is still an [optimization barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L227-L243) in place, which will become the default after the feature is deprecated. How Has This Been Tested? --- Existing tests pass. What process can a PR reviewer use to test or verify this change? --- Check the claims made in the PR about the feature behavior.
1 parent fa53e0e commit 6527b77

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

applications/minotari_app_grpc/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ prost = "0.11.9"
2424
prost-types = "0.11.9"
2525
rand = "0.8"
2626
rcgen = "0.11.3"
27-
subtle = { version = "2.5.0", features = ["core_hint_black_box"] }
27+
subtle = "2.5.0"
2828
thiserror = "1"
2929
tokio = { version = "1.36", features = ["fs"] }
3030
tonic = { version = "0.8.3", features = ["tls"]}

0 commit comments

Comments
 (0)