Skip to content

Remove OutOfMemory error from popen.new and popen.read #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #5096
TarantoolBot opened this issue Aug 7, 2023 · 1 comment · Fixed by #5101
Closed
Tracked by #5096

Remove OutOfMemory error from popen.new and popen.read #3608

TarantoolBot opened this issue Aug 7, 2023 · 1 comment · Fixed by #5101
Assignees
@AArdeev
Labels
3.0 behavior change [nature] Сhange in existing behavior reference [location] Tarantool manual, Reference part

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Aug 7, 2023 •
edited by xuniq
Loading

Product: Tarantool
Since:
Root document: 1) https://www.tarantool.io/en/doc/latest/reference/reference_lua/popen/#popen-new
2) https://www.tarantool.io/en/doc/latest/reference/reference_lua/popen/#popen-read
SME: @ locker

Can be done together with #3609

Details

These functions don't raise the OutOfMemory exception anymore so all
mentions of it should be removed from the documentation:
@xuniq xuniq added reference [location] Tarantool manual, Reference part behavior change [nature] Сhange in existing behavior labels Aug 9, 2023
@xuniq xuniq self-assigned this Aug 9, 2023
@xuniq xuniq added the 3.0 label Aug 10, 2023
@xuniq xuniq removed their assignment Aug 10, 2023
@veod32 veod32 mentioned this issue May 6, 2025
Open
5 tasks
@AArdeev
Copy link
Contributor

AArdeev commented May 12, 2025

The OutOfMemory error must be removed from popen.new and popen.read. No versioning required because it was never returned at all for the mentioned functions.

@AArdeev AArdeev linked a pull request May 13, 2025 that will close this issue
Fixes incorrect error description #5101
Merged
AArdeev added a commit that referenced this issue May 13, 2025
@AArdeev
Remove incorrect error and add new option
f740f43 
* Remove incorrect OutOfMemory error
* Add new inherit_fds option description to popen.new

Fixes #3608
Fixes #3609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArdeev AArdeev

Labels
3.0 behavior change [nature] Сhange in existing behavior reference [location] Tarantool manual, Reference part
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes incorrect error description tarantool/doc
3 participants
@TarantoolBot @xuniq @AArdeev