Skip to content

Commit c20ef56

Browse files
test: skip cartridge hotreload on old Tarantool
Running tests for cartridge roles reload with vshard 0.1.22+ may stuck on old Tarantool versions (1.10.6, 2.2, 2.3, 2.4). The reason is rather unclear (it is somehow related to new vshard retrying utils), but since it concerns out of support versions, it is not worth to inspect it too long or file an issue. ``` main/137/vshard.recovery util.lua:103 E> recovery_f has been failed: .../.rocks/share/tarantool/vshard/storage/init.lua:1268: assertion failed! main/136/vshard.gc util.lua:103 E> gc_bucket_f has been failed: .../.rocks/share/tarantool/vshard/storage/init.lua:2530: assertion failed! ```
1 parent 7210028 commit c20ef56

File tree

6 files changed

+28
-1
lines changed

6 files changed

+28
-1
lines changed

deps.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
set -e
55

66
# Test dependencies:
7-
tarantoolctl rocks install luatest 0.5.7
7+
tarantoolctl rocks install luatest
88
tarantoolctl rocks install luacheck 0.25.0
99
tarantoolctl rocks install luacov 0.13.0
1010

test/helper.lua

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require('strict').on()
22

33
local t = require('luatest')
4+
local luatest_utils = require('luatest.utils')
45

56
local log = require('log')
67
local checks = require('checks')
@@ -551,4 +552,17 @@ function helpers.is_cartridge_hotreload_supported()
551552
return crud_utils.is_cartridge_hotreload_supported()
552553
end
553554

555+
function helpers.skip_old_tarantool_cartridge_hotreload()
556+
-- Cartridge hotreload tests stuck for vshard 0.1.22+ on Tarantool 1.10.6, 2.2, 2.3 and 2.4.
557+
-- Logs display a lot of following errors:
558+
-- main/137/vshard.recovery util.lua:103 E> recovery_f has been failed: .../.rocks/share/tarantool/vshard/storage/init.lua:1268: assertion failed!
559+
-- main/136/vshard.gc util.lua:103 E> gc_bucket_f has been failed: .../.rocks/share/tarantool/vshard/storage/init.lua:2530: assertion failed!
560+
local tarantool_version = luatest_utils.get_tarantool_version()
561+
t.skip_if(luatest_utils.version_ge(luatest_utils.version(1, 10, 13), tarantool_version),
562+
"Cartridge hotreload tests stuck for vshard 0.1.22+ on Tarantool 1.10.6")
563+
t.skip_if(luatest_utils.version_ge(tarantool_version, luatest_utils.version(2, 0, 0))
564+
and luatest_utils.version_ge(luatest_utils.version(2, 5, 1), tarantool_version),
565+
"Cartridge hotreload tests stuck for vshard 0.1.22+ on Tarantool 2.2, 2.3 and 2.4")
566+
end
567+
554568
return helpers

test/integration/cfg_test.lua

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ end
7272
group.test_role_reload_preserves_values = function(g)
7373
t.skip_if(not helpers.is_cartridge_hotreload_supported(),
7474
"Cartridge roles reload is not supported")
75+
helpers.skip_old_tarantool_cartridge_hotreload()
7576

7677
local router = g.cluster:server('router')
7778

test/integration/ddl_sharding_info_reload_test.lua

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,7 @@ for sharding_case_name, sharding_case in pairs(sharding_cases) do
307307
((reload_case == 'reload_roles')
308308
and not helpers.is_cartridge_hotreload_supported()),
309309
"Cartridge roles reload is not supported")
310+
helpers.skip_old_tarantool_cartridge_hotreload()
310311

311312
local storage = g.cluster:server('s1-master')
312313

@@ -333,6 +334,12 @@ for _, sharding_case in pairs(sharding_cases) do
333334
sharding_case.ddl_space, reload_case_name)
334335

335336
pgroup_storage[test_name] = function(g)
337+
t.skip_if(
338+
((reload_case == 'reload_roles')
339+
and not helpers.is_cartridge_hotreload_supported()),
340+
"Cartridge roles reload is not supported")
341+
helpers.skip_old_tarantool_cartridge_hotreload()
342+
336343
local storage = g.cluster:server('s1-master')
337344

338345
-- Init the cache.

test/integration/reload_test.lua

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ end)
7979
function g.test_router()
8080
t.skip_if(not helpers.is_cartridge_hotreload_supported(),
8181
"Cartridge roles reload is not supported")
82+
helpers.skip_old_tarantool_cartridge_hotreload()
8283

8384
g.highload_fiber = fiber.new(highload_loop, 'A')
8485

@@ -104,6 +105,7 @@ end
104105
function g.test_storage()
105106
t.skip_if(not helpers.is_cartridge_hotreload_supported(),
106107
"Cartridge roles reload is not supported")
108+
helpers.skip_old_tarantool_cartridge_hotreload()
107109

108110
g.highload_fiber = fiber.new(highload_loop, 'B')
109111

test/integration/stats_test.lua

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -777,6 +777,7 @@ pgroup.test_role_reload_do_not_reset_observations = function(g)
777777
t.skip_if((g.params.args.driver == 'metrics')
778778
and helpers.is_metrics_0_12_0_or_older(),
779779
"See https://github.com/tarantool/metrics/issues/334")
780+
helpers.skip_old_tarantool_cartridge_hotreload()
780781

781782
local stats_before = get_stats(g)
782783

@@ -1091,6 +1092,7 @@ group_metrics.test_role_reload_do_not_reset_metrics_observations = function(g)
10911092
"Cartridge roles reload is not supported")
10921093
t.skip_if(helpers.is_metrics_0_12_0_or_older(),
10931094
"See https://github.com/tarantool/metrics/issues/334")
1095+
helpers.skip_old_tarantool_cartridge_hotreload()
10941096

10951097
helpers.reload_roles(g.cluster:server('router'))
10961098
g.router:eval("crud = require('crud')")
@@ -1130,6 +1132,7 @@ group_metrics.before_test(
11301132
group_metrics.test_stats_changed_in_metrics_registry_after_role_reload = function(g)
11311133
t.skip_if(not helpers.is_cartridge_hotreload_supported(),
11321134
"Cartridge roles reload is not supported")
1135+
helpers.skip_old_tarantool_cartridge_hotreload()
11331136

11341137
helpers.reload_roles(g.cluster:server('router'))
11351138
g.router:eval("crud = require('crud')")

0 commit comments

Comments
 (0)