-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't workingcriticalCritical issues that must be fixed immediatelyCritical issues that must be fixed immediatelytestingIssues related to tests and test coverageIssues related to tests and test coverage
Description
Problem
The test TestLoad_NonExistentFile
in internal/config/config_test.go:328
is failing because it expects an os.IsNotExist
error but gets nil
instead.
Root Cause
The Load
function tries multiple config file locations including the home directory .goshrc
file. If any of these files exist, the function succeeds instead of returning the expected error.
Current Behavior
- Test expects
os.IsNotExist
error when loading from non-existent directory - Function returns
nil
because it falls back to checking~/.goshrc
Expected Fix
Either:
- Fix the test logic to account for fallback behavior, OR
- Modify the Load function to match the expected semantics
Files Affected
internal/config/config_test.go
(line 328-336)internal/config/config.go
(Load function logic)
Priority
Critical - Failing tests block development workflow and CI/CD.
Reference
See TODO.md item #2
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcriticalCritical issues that must be fixed immediatelyCritical issues that must be fixed immediatelytestingIssues related to tests and test coverageIssues related to tests and test coverage