Replies: 3 comments 1 reply
-
Hello @vinceglb ! Having more options to load photos and save cropped versions is definitely a must-have, especially as a combination with a file picker library like FileKit, which will usually be used as a pair with krop (I personally recommend that and will update the sample accordingly). However, the design of the api should be abstract. I think providing such an abstraction should be in the core module, and the integration with 3rd party libraries should be through extension modules. As for now, I'm quite busy with my main project, but I would find spare time to discuss and merge your PR if you can work on a solution. |
Beta Was this translation helpful? Give feedback.
-
@vanniktech I would appreciate your opinion on this suggestion from @vinceglb, as a continuation for the #30 discussion. |
Beta Was this translation helpful? Give feedback.
-
Hello @vinceglb! Also, I added a section to the README file, about extensions, would you please take a look, did I miss anything? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi guys! I'm interested in facilitating the integration between
FileKit
andkrop
.The idea would be to call
imageCropper.crop()
directly with aPlatformFile
in parameter. We can also imagine using this integration to make it easier to save the cropped image.I know that you are not in favor of supporting third-party libraries that I can clearly understand. But I'm interested in having your thoughts.
What is the best approach to achieve this integration?
One idea I had is that I can create a dedicated module like
filekit-krop
based onkrop-core
that brings some extensions. But maybe there are better ways?Anyway, thanks for your library 🙏
Beta Was this translation helpful? Give feedback.
All reactions