Skip to content

Finch Adapter? #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
suprafly opened this issue Apr 24, 2023 · 3 comments · Fixed by #203
Closed

Finch Adapter? #164

suprafly opened this issue Apr 24, 2023 · 3 comments · Fixed by #203

Comments

@suprafly
Copy link

Not so much an issue, but I wanted to see if there is a desire for a Finch adapter? I have a simple one working, and would be happy to make a PR. I did not see any contribution guidelines, so I figured it would be best to open an issue first.

The latest version of Phoenix ships with Finch by default, so having an adapter means one less dependency users of your library will need if they are coming from Phoenix.

Cheers.
@mwhitworth
Copy link
Collaborator

More adapters are no bad thing. Happy to see a PR for this

@mwhitworth mwhitworth mentioned this issue Apr 14, 2024
Merged
@mwhitworth
Copy link
Collaborator

I put together an initial version of a Finch adapter.

It needs more testing, and I'd like to support third-party library versions as early as possible (given the general nature of this library) - so I'll make another pass at this before merging and releasing.

@mwhitworth
Copy link
Collaborator

Buffer response mode is now supported - work to support streaming responses will be tracked in #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

initial Finch adapter tallarium/reverse_proxy_plug
2 participants
@suprafly @mwhitworth