You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have created a PR to add something to Tailwind, and I have a couple of questions.
I have forked the project, cloned it, and create a new bracnh from master.
First of all, should I create a PR against the master branch on the original repository? It seems unusual but I didn't read anything about it in the Contributing doc.
Secondly, and most importantly, the tests fail. They fail even without my changes. I ran npm install and then npm test and this is the result:
Test Suites: 30 failed, 35 passed, 65 total
Tests: 3 failed, 8299 passed, 8302 total
Snapshots: 0 total
Time: 10.543 s, estimated 12 s
Ran all test suites.
An example of a failure is:
FAIL __tests__/cli.test.js
● Test suite failed to run
Cannot find module '../lib/util/withAlphaVariable' from 'jit/pluginUtils.js'
Require stack:
jit/pluginUtils.js
src/plugins/backdropBlur.js
src/plugins/index.js
src/corePlugins.js
src/processTailwindFeatures.js
src/index.js
src/cli/commands/build.js
src/cli/commands/index.js
src/cli/main.js
__tests__/cli.test.js
1 | const selectorParser = require('postcss-selector-parser')
2 | const postcss = require('postcss')
> 3 | const { toRgba } = require('../lib/util/withAlphaVariable')
| ^
4 | const { nameClass, escapeCommas } = require('./lib/utils')
5 |
6 | function updateAllClasses(selectors, updateClass) {
at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
at Object.<anonymous> (jit/pluginUtils.js:3:20)
The other error are all like this, sometime it's a different module, but always from either jit/pluginUtils.js or jit/index.js.
Is there something I didn't do and I should have? Should I submit the PR anyway?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I have created a PR to add something to Tailwind, and I have a couple of questions.
I have forked the project, cloned it, and create a new bracnh from
master
.First of all, should I create a PR against the master branch on the original repository? It seems unusual but I didn't read anything about it in the Contributing doc.
Secondly, and most importantly, the tests fail. They fail even without my changes. I ran
npm install
and thennpm test
and this is the result:An example of a failure is:
The other error are all like this, sometime it's a different module, but always from either
jit/pluginUtils.js
orjit/index.js
.Is there something I didn't do and I should have? Should I submit the PR anyway?
Thanks
Giulio
Beta Was this translation helpful? Give feedback.
All reactions