Change from top to bottom margin? #2935
-
|
Hey @adamwathan , I noticed that on the new v2 website you "switched" from top margin to bottom margin. So my question: Could you please explain if there's any specific reason on that very site Would be very grateful for just a brief explanation, I'm very curious what led to the change :) Thanks! |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
Beta Was this translation helpful? Give feedback.
-
|
Adam might chime in, but I wouldn't read too much into this - the short answer is: @bradlc build the new website, not Adam 😅 We're trying to standardize our coding style as much as possible across all our products but we're effectively still a fairly "new" team working on different things 👍 My personal preference is to apply margin on Each element on a page should be responsible for its own layout. If the incoming element needs vertical spacing between itself and the previous element, it should handle that spacing itself. The previous element should not have to say:
Instead, I want the current incoming element to say:
Not sure it even makes sense explained like this - but it sure makes sense in my head 😅 |
Beta Was this translation helpful? Give feedback.
-
|
that's really smart |
Beta Was this translation helpful? Give feedback.
-
|
Hey @simonswiss thank you for your reply and I absolutely agree with that and that's the way I'm doing it since I first But yeah that explains why it is different on the new website, thank you :D |
Beta Was this translation helpful? Give feedback.
Adam might chime in, but I wouldn't read too much into this - the short answer is: @bradlc build the new website, not Adam 😅
We're trying to standardize our coding style as much as possible across all our products but we're effectively still a fairly "new" team working on different things 👍
My personal preference is to apply margin on
topandleftonly for most situations (in a "left-to-right" scenario), for the following reason:Each element on a page should be responsible for its own layout. If the incoming element needs vertical spacing between itself and the previous element, it should handle that spacing itself. The previous element should not have to say: