Should purge preserveHtmlElements still work for user-defined extractors?

[JNavith]

Edit: This has been closed by #2704

This isn't a formal issue / bug report so I'm putting it in Discussions instead.

This is the current implementation of purge:

      defaultExtractor: (content) => {
        // Capture as liberally as possible, including things like `h-(screen-1.5)`
        const broadMatches = content.match(/[^<>"'`\s]*[^<>"'`\s:]/g) || []
        const broadMatchesWithoutTrailingSlash = broadMatches.map((match) => _.trimEnd(match, '\\'))

        // Capture classes within other delimiters like .block(class="w-1/2") in Pug
        const innerMatches = content.match(/[^<>"'`\s.(){}[\]#=%]*[^<>"'`\s.(){}[\]#=%:]/g) || []

        const matches = broadMatches.concat(broadMatchesWithoutTrailingSlash).concat(innerMatches)

        if (_.get(config, 'purge.preserveHtmlElements', true)) {
          return [...htmlTags].concat(matches)
        } else {
          return matches
        }
      },
      ...config.purge.options,

Notice this means that if the defaultExtractor is overridden by the user that preserveHtmlElements no longer takes effect.

Is that intended? Because if not I can imagine PRing something along the lines of

const ourVeryGoodExtractor = (content) => {
        // Capture as liberally as possible, including things like `h-(screen-1.5)`
        const broadMatches = content.match(/[^<>"'`\s]*[^<>"'`\s:]/g) || []
        const broadMatchesWithoutTrailingSlash = broadMatches.map((match) => _.trimEnd(match, '\\'))

        // Capture classes within other delimiters like .block(class="w-1/2") in Pug
        const innerMatches = content.match(/[^<>"'`\s.(){}[\]#=%]*[^<>"'`\s.(){}[\]#=%:]/g) || []

        return broadMatches.concat(broadMatchesWithoutTrailingSlash).concat(innerMatches)
};

// ...
const { defaultExtractor, ...purgeOptions } = config.purge.options;
purgecss({
  // ...
  defaultExtractor: (content) => (defaultExtractor ?? ourVeryGoodExtractor)(content).concat(_.get(config, 'purge.preserveHtmlElements', true) ? htmlTags : []),
  ...purgeOptions,
}),

to make it work again.
Edit: This has been closed by #2704

[adamwathan]

Good Q, I think what you're proposing maybe is more intuitive. Would welcome a PR for it I think, don't see the harm in it as people can opt-out easily enough.