feat(event): add tags filter to Push struct for event handling (#157)

amitksingh1490 · web-flow · commit 26ef5f93ce0a · 2025-05-06T17:57:29.000+05:30
* feat(event): add tags filter to Push struct for event handling

* refactor: simplify string formatting in various display implementations

* feat(workflow): add tag filter to Push event for versioning

* feat(workflow): add tag support for push events in CI configuration

* feat(workflow): add tag support for push events in autofix CI configuration
diff --git a/.github/workflows/autofix.yml b/.github/workflows/autofix.yml
@@ -29,6 +29,8 @@ on:
   push:
     branches:
     - main
+    tags:
+    - v*
 jobs:
   lint:
     name: Lint Fix
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,6 +29,8 @@ on:
   push:
     branches:
     - main
+    tags:
+    - v*
 jobs:
   build:
     name: Build and Test
diff --git a/crates/gh-workflow-tailcall/src/standard.rs b/crates/gh-workflow-tailcall/src/standard.rs
@@ -239,7 +239,7 @@ impl StandardWorkflow {
 
     fn workflow_event(&self) -> Event {
         Event::default()
-            .push(Push::default().add_branch("main"))
+            .push(Push::default().add_branch("main").add_tag("v*"))
             .pull_request(
                 PullRequest::default()
                     .add_type(PullRequestType::Opened)
diff --git a/crates/gh-workflow/src/cargo.rs b/crates/gh-workflow/src/cargo.rs
@@ -74,7 +74,7 @@ impl From<Cargo> for Step<Run> {
         let mut command = vec!["cargo".to_string()];
 
         if let Some(toolchain) = value.toolchain {
-            command.push(format!("+{}", toolchain));
+            command.push(format!("+{toolchain}"));
         }
 
         command.push(value.command);
diff --git a/crates/gh-workflow/src/ctx.rs b/crates/gh-workflow/src/ctx.rs
@@ -202,25 +202,25 @@ impl fmt::Display for Step {
             Step::Root => write!(f, ""),
             Step::Select { name, object } => {
                 if matches!(**object, Step::Root) {
-                    write!(f, "{}", name)
+                    write!(f, "{name}")
                 } else {
-                    write!(f, "{}.{}", object, name)
+                    write!(f, "{object}.{name}")
                 }
             }
             Step::Eq { left, right } => {
-                write!(f, "{} == {}", left, right)
+                write!(f, "{left} == {right}")
             }
             Step::And { left, right } => {
-                write!(f, "{} && {}", left, right)
+                write!(f, "{left} && {right}")
             }
             Step::Or { left, right } => {
-                write!(f, "{} || {}", left, right)
+                write!(f, "{left} || {right}")
             }
             Step::Literal(value) => {
-                write!(f, "'{}'", value)
+                write!(f, "'{value}'")
             }
             Step::Concat { left, right } => {
-                write!(f, "{}{}", left, right)
+                write!(f, "{left}{right}")
             }
         }
     }
diff --git a/crates/gh-workflow/src/event.rs b/crates/gh-workflow/src/event.rs
@@ -643,6 +643,9 @@ pub struct Push {
     /// Filter on specific file paths
     #[serde(default, skip_serializing_if = "Vec::is_empty")]
     pub paths: Vec<String>,
+    /// Filter on specific tags
+    #[serde(default, skip_serializing_if = "Vec::is_empty")]
+    pub tags: Vec<String>,
 }
 
 impl Push {
@@ -657,6 +660,12 @@ impl Push {
         self.paths.push(path.into());
         self
     }
+
+    /// Adds a tag name to filter on
+    pub fn add_tag<S: Into<String>>(mut self, tag: S) -> Self {
+        self.tags.push(tag.into());
+        self
+    }
 }
 
 /// Types of registry package events
diff --git a/crates/gh-workflow/src/generate.rs b/crates/gh-workflow/src/generate.rs
@@ -1,7 +1,6 @@
 //! This module provides functionality to customize generation of the GitHub
 //! Actions workflow files.
 
-use std::io::ErrorKind;
 use std::path::PathBuf;
 use std::process::Command;
 
@@ -70,7 +69,7 @@ impl Generate {
                 }
                 Err(Error::MissingWorkflowFile(path)) => {
                     std::fs::create_dir_all(path.parent().ok_or(Error::IO(
-                        std::io::Error::new(ErrorKind::Other, "Invalid parent dir(s) path"),
+                        std::io::Error::other("Invalid parent dir(s) path"),
                     ))?)?;
                     std::fs::write(path.clone(), content)?;
                     println!("Generated workflow file: {}", path.display());
@@ -113,13 +112,13 @@ fn organize_job_dependency(mut workflow: Workflow) -> Workflow {
                     job_ids.push(id.to_owned());
                 } else {
                     // Create a job-id for the job
-                    let id = format!("job-{}", job_id);
+                    let id = format!("job-{job_id}");
 
                     // Add job id as the dependency
                     job_ids.push(id.clone());
 
                     // Insert the missing job into the new_jobs
-                    new_jobs.insert(format!("job-{}", job_id), job.clone());
+                    new_jobs.insert(format!("job-{job_id}"), job.clone());
 
                     job_id += 1;
                 }
diff --git a/crates/gh-workflow/src/rust_flag.rs b/crates/gh-workflow/src/rust_flag.rs
@@ -56,14 +56,14 @@ impl Display for RustFlags {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
             RustFlags::Lint(name, lint) => match lint {
-                Lint::Allow => write!(f, "-A{}", name),
-                Lint::Warn => write!(f, "-W{}", name),
-                Lint::Deny => write!(f, "-D{}", name),
-                Lint::Forbid => write!(f, "-F{}", name),
-                Lint::Codegen => write!(f, "-C{}", name),
-                Lint::Experiment => write!(f, "-Z{}", name),
+                Lint::Allow => write!(f, "-A{name}"),
+                Lint::Warn => write!(f, "-W{name}"),
+                Lint::Deny => write!(f, "-D{name}"),
+                Lint::Forbid => write!(f, "-F{name}"),
+                Lint::Codegen => write!(f, "-C{name}"),
+                Lint::Experiment => write!(f, "-Z{name}"),
             },
-            RustFlags::Combine(lhs, rhs) => write!(f, "{} {}", lhs, rhs),
+            RustFlags::Combine(lhs, rhs) => write!(f, "{lhs} {rhs}"),
         }
     }
 }
diff --git a/crates/gh-workflow/src/toolchain.rs b/crates/gh-workflow/src/toolchain.rs
@@ -44,7 +44,7 @@ impl Display for Component {
             Component::Rustfmt => "rustfmt",
             Component::RustDoc => "rust-doc",
         };
-        write!(f, "{}", val)
+        write!(f, "{val}")
     }
 }
 
@@ -64,7 +64,7 @@ impl Display for Arch {
             Arch::Arm => "arm",
             Arch::Wasm32 => "wasm32",
         };
-        write!(f, "{}", val)
+        write!(f, "{val}")
     }
 }
 
@@ -82,7 +82,7 @@ impl Display for Vendor {
             Vendor::Apple => "apple",
             Vendor::PC => "pc",
         };
-        write!(f, "{}", val)
+        write!(f, "{val}")
     }
 }
 
@@ -102,7 +102,7 @@ impl Display for System {
             System::Linux => "linux",
             System::Darwin => "darwin",
         };
-        write!(f, "{}", val)
+        write!(f, "{val}")
     }
 }
 
@@ -122,7 +122,7 @@ impl Display for Abi {
             Abi::Msvc => "msvc",
             Abi::Musl => "musl",
         };
-        write!(f, "{}", val)
+        write!(f, "{val}")
     }
 }
 
@@ -205,10 +205,10 @@ impl From<Toolchain> for Step<Use> {
                 Version::Stable => "stable".to_string(),
                 Version::Nightly => "nightly".to_string(),
                 Version::Custom((major, minor, patch)) => {
-                    format!("{}.{}.{}", major, minor, patch)
+                    format!("{major}.{minor}.{patch}")
                 }
             })
-            .reduce(|acc, a| format!("{}, {}", acc, a));
+            .reduce(|acc, a| format!("{acc}, {a}"));
 
         let mut input = Input::default();
 
@@ -233,7 +233,7 @@ impl From<Toolchain> for Step<Use> {
                 .components
                 .iter()
                 .map(|c| c.to_string())
-                .reduce(|acc, a| format!("{}, {}", acc, a))
+                .reduce(|acc, a| format!("{acc}, {a}"))
                 .unwrap_or_default();
 
             input = input.add("components", components);
@@ -252,7 +252,7 @@ impl From<Toolchain> for Step<Use> {
             let cache_workspaces = value
                 .cache_workspaces
                 .iter()
-                .fold("".to_string(), |acc, a| format!("{}\n{}", acc, a));
+                .fold("".to_string(), |acc, a| format!("{acc}\n{a}"));
 
             input = input.add("cache-workspaces", cache_workspaces);
         }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ impl From<Cargo> for Step<Run> {`
`74`	`74`	`let mut command = vec!["cargo".to_string()];`
`75`	`75`
`76`	`76`	`if let Some(toolchain) = value.toolchain {`
`77`		`- command.push(format!("+{}", toolchain));`
	`77`	`+ command.push(format!("+{toolchain}"));`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`command.push(value.command);`
Original file line number	Diff line number	Diff line change
`@@ -202,25 +202,25 @@ impl fmt::Display for Step {`
`202`	`202`	`Step::Root => write!(f, ""),`
`203`	`203`	`Step::Select { name, object } => {`
`204`	`204`	`if matches!(**object, Step::Root) {`
`205`		`- write!(f, "{}", name)`
	`205`	`+ write!(f, "{name}")`
`206`	`206`	`} else {`
`207`		`- write!(f, "{}.{}", object, name)`
	`207`	`+ write!(f, "{object}.{name}")`
`208`	`208`	`}`
`209`	`209`	`}`
`210`	`210`	`Step::Eq { left, right } => {`
`211`		`- write!(f, "{} == {}", left, right)`
	`211`	`+ write!(f, "{left} == {right}")`
`212`	`212`	`}`
`213`	`213`	`Step::And { left, right } => {`
`214`		`- write!(f, "{} && {}", left, right)`
	`214`	`+ write!(f, "{left} && {right}")`
`215`	`215`	`}`
`216`	`216`	`Step::Or { left, right } => {`
`217`		`- write!(f, "{} \|\| {}", left, right)`
	`217`	`+ write!(f, "{left} \|\| {right}")`
`218`	`218`	`}`
`219`	`219`	`Step::Literal(value) => {`
`220`		`- write!(f, "'{}'", value)`
	`220`	`+ write!(f, "'{value}'")`
`221`	`221`	`}`
`222`	`222`	`Step::Concat { left, right } => {`
`223`		`- write!(f, "{}{}", left, right)`
	`223`	`+ write!(f, "{left}{right}")`
`224`	`224`	`}`
`225`	`225`	`}`
`226`	`226`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ impl Display for Component {`
`44`	`44`	`Component::Rustfmt => "rustfmt",`
`45`	`45`	`Component::RustDoc => "rust-doc",`
`46`	`46`	`};`
`47`		`- write!(f, "{}", val)`
	`47`	`+ write!(f, "{val}")`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`
`@@ -64,7 +64,7 @@ impl Display for Arch {`
`64`	`64`	`Arch::Arm => "arm",`
`65`	`65`	`Arch::Wasm32 => "wasm32",`
`66`	`66`	`};`
`67`		`- write!(f, "{}", val)`
	`67`	`+ write!(f, "{val}")`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`@@ -82,7 +82,7 @@ impl Display for Vendor {`
`82`	`82`	`Vendor::Apple => "apple",`
`83`	`83`	`Vendor::PC => "pc",`
`84`	`84`	`};`
`85`		`- write!(f, "{}", val)`
	`85`	`+ write!(f, "{val}")`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`@@ -102,7 +102,7 @@ impl Display for System {`
`102`	`102`	`System::Linux => "linux",`
`103`	`103`	`System::Darwin => "darwin",`
`104`	`104`	`};`
`105`		`- write!(f, "{}", val)`
	`105`	`+ write!(f, "{val}")`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`@@ -122,7 +122,7 @@ impl Display for Abi {`
`122`	`122`	`Abi::Msvc => "msvc",`
`123`	`123`	`Abi::Musl => "musl",`
`124`	`124`	`};`
`125`		`- write!(f, "{}", val)`
	`125`	`+ write!(f, "{val}")`
`126`	`126`	`}`
`127`	`127`	`}`
`128`	`128`
`@@ -205,10 +205,10 @@ impl From<Toolchain> for Step<Use> {`
`205`	`205`	`Version::Stable => "stable".to_string(),`
`206`	`206`	`Version::Nightly => "nightly".to_string(),`
`207`	`207`	`Version::Custom((major, minor, patch)) => {`
`208`		`- format!("{}.{}.{}", major, minor, patch)`
	`208`	`+ format!("{major}.{minor}.{patch}")`
`209`	`209`	`}`
`210`	`210`	`})`
`211`		`- .reduce(\|acc, a\| format!("{}, {}", acc, a));`
	`211`	`+ .reduce(\|acc, a\| format!("{acc}, {a}"));`
`212`	`212`
`213`	`213`	`let mut input = Input::default();`
`214`	`214`
`@@ -233,7 +233,7 @@ impl From<Toolchain> for Step<Use> {`
`233`	`233`	`.components`
`234`	`234`	`.iter()`
`235`	`235`	`.map(\|c\| c.to_string())`
`236`		`- .reduce(\|acc, a\| format!("{}, {}", acc, a))`
	`236`	`+ .reduce(\|acc, a\| format!("{acc}, {a}"))`
`237`	`237`	`.unwrap_or_default();`
`238`	`238`
`239`	`239`	`input = input.add("components", components);`
`@@ -252,7 +252,7 @@ impl From<Toolchain> for Step<Use> {`
`252`	`252`	`let cache_workspaces = value`
`253`	`253`	`.cache_workspaces`
`254`	`254`	`.iter()`
`255`		`- .fold("".to_string(), \|acc, a\| format!("{}\n{}", acc, a));`
	`255`	`+ .fold("".to_string(), \|acc, a\| format!("{acc}\n{a}"));`
`256`	`256`
`257`	`257`	`input = input.add("cache-workspaces", cache_workspaces);`
`258`	`258`	`}`