Skip to content

Remove dependency on git #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eadwu opened this issue Apr 11, 2025 · 4 comments · May be fixed by #3692
Open

Remove dependency on git #3684

eadwu opened this issue Apr 11, 2025 · 4 comments · May be fixed by #3692

Comments

@eadwu
Copy link

eadwu commented Apr 11, 2025

mkosi commit the issue has been seen with

mkosi 26~devel

Used host distribution

Fedora 41

Used target distribution

N/A

Linux kernel version used

6.13.9-200.fc41.x86_64

CPU architectures issue was seen on

x86_64

Unexpected behaviour you saw

❯  mkosi -f sandbox -- meson setup build

‣ Cannot check mkosi git version, not running mkosi from a git repository

Installed with README.md provided instructions

dnf config-manager addrepo --from-repofile=https://download.opensuse.org/repositories/system:systemd/Fedora_41/system:systemd.repo
dnf install mkosi

Used mkosi config

N/A

mkosi output

N/A
@eadwu
Copy link
Author

eadwu commented Apr 11, 2025

pipx

 pipx install git+https://github.com/systemd/mkosi.git
mkosi --version

‣ Cannot check mkosi git version, not running mkosi from a git repository

git clone (selinux is disabled on boot already)

 ../mkosi/bin/mkosi -f sandbox -- meson setup build

cp: setting attribute 'security.selinux' for 'security.selinux': Operation not permitted
‣ "cp --recursive --no-dereference --preserve=mode,links,timestamps,ownership,xattr --reflink=auto --copy-contents /work/usr/share/crypto-policies/back-ends/DEFAULT /work/var/home/sss/.cache/mkosi/mkosi-metadata-ij_gsjh8/etc/crypto-policies/back-ends --no-target-directory" returned non-zero exit code 1.

zppy

systemd on  main 
❯   ../mkosi/builddir/mkosi -f sandbox -- meson setup build

‣ Cannot check mkosi git version, not running mkosi from a git repository

@behrmann
Copy link
Contributor

You are trying to build something that requires at least specific git version of mkosi, I think, systemd I assume, since that's probably the only project using this feature out there at this point, so you must run mkosi from a git checkout.

Can you provide the debug output for the run from a git checkout with the SELinux problem?

@DaanDeMeyer
Copy link
Contributor

@eadwu mkosi does not have a required dependency on git, using mkosi from within the systemd repository does have a required dependency on git as long as we're using features that are not in a released version so that we can ensure the mkosi version is sufficiently new and can show a proper error if it isn't. Please run mkosi from git for now when using it in the systemd repository. Hopefully at some point in the future we won't have to rely on unreleased features in the systemd repo anymore and can drop the git requirement.

As for the other selinux error, can you tell us a bit more about your setup? Specifically, the output of stat --file-system /var/home/sss/.cache would be interesting.

@eadwu
Copy link
Author

eadwu commented Apr 11, 2025

Got it, I see, error message confused me.

mkosi commit 8235ddb

stat --file-system /var/home/sss/.cache

  File: "/var/home/sss/.cache"
    ID: 9d8d1ae700913089 Namelen: 255     Type: zfs
Block size: 131072     Fundamental block size: 131072
Blocks: Total: 3055620    Free: 2845742    Available: 2845742
Inodes: Total: 728992290  Free: 728510032

SELinux is disabled on boot with selinux=0

❯  sestatus               
SELinux status:                 disabled

It appears to work after sudo and fixing the error message regarding safe repositories with git.

DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Apr 15, 2025
This also fails with permission denied errors so let's skip it on
zfs as well.

Fixes systemd#3684
@DaanDeMeyer DaanDeMeyer linked a pull request Apr 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants