Skip to content

Commit 8ad9c0c

Browse files
committed
scripts: Version EC separately from SBIOS
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed. At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. Ref: f4f4d5b ("Build EC as a submodule, specifying version") Signed-off-by: Tim Crawford <tcrawford@system76.com>
1 parent 3e19b73 commit 8ad9c0c

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ date followed by an underscore and a short git revision. To see if specific
66
features apply to your model and firmware version, see the
77
[feature matrix](./FEATURES.md).
88

9+
## unreleased
10+
11+
- Changed the EC version to be distinct from the SBIOS version
12+
913
## 2024-01-18
1014

1115
- darp9: Added SSD RTD3 configs to fix suspend with some drives

scripts/_build/ec.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ done < "$1"
2020
BUILD_DIR="build"
2121

2222
make -C ec BUILD="$BUILD_DIR" clean
23-
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
23+
make -C ec "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
2424
cp "ec/$BUILD_DIR/ec.rom" "$2"

scripts/build.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ KERNELVERSION="${VERSION}" \
8686
# Rebuild EC firmware for System76 EC models
8787
if [ ! -e "${MODEL_DIR}/ec.rom" ] && [ -e "${MODEL_DIR}/ec.config" ]
8888
then
89-
env VERSION="${VERSION}" \
90-
./scripts/_build/ec.sh \
89+
./scripts/_build/ec.sh \
9190
"${MODEL_DIR}/ec.config" \
9291
"${BUILD}/ec.rom"
9392
fi

0 commit comments

Comments
 (0)