Skip to content

Commit 8172c03

Browse files
authored
Merge pull request #213 from keytouch/master
procfs: Remove unnecessary cleanup on proc_create failure
2 parents 433d031 + 5e2b7aa commit 8172c03

File tree

4 files changed

+0
-4
lines changed

4 files changed

+0
-4
lines changed

examples/procfs2.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ static int __init procfs2_init(void)
7777
{
7878
our_proc_file = proc_create(PROCFS_NAME, 0644, NULL, &proc_file_fops);
7979
if (NULL == our_proc_file) {
80-
proc_remove(our_proc_file);
8180
pr_alert("Error:Could not initialize /proc/%s\n", PROCFS_NAME);
8281
return -ENOMEM;
8382
}

examples/procfs3.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ static int __init procfs3_init(void)
8282
our_proc_file = proc_create(PROCFS_ENTRY_FILENAME, 0644, NULL,
8383
&file_ops_4_our_proc_file);
8484
if (our_proc_file == NULL) {
85-
remove_proc_entry(PROCFS_ENTRY_FILENAME, NULL);
8685
pr_debug("Error: Could not initialize /proc/%s\n",
8786
PROCFS_ENTRY_FILENAME);
8887
return -ENOMEM;

examples/procfs4.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ static int __init procfs4_init(void)
9898

9999
entry = proc_create(PROC_NAME, 0, NULL, &my_file_ops);
100100
if (entry == NULL) {
101-
remove_proc_entry(PROC_NAME, NULL);
102101
pr_debug("Error: Could not initialize /proc/%s\n", PROC_NAME);
103102
return -ENOMEM;
104103
}

examples/sleep.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ static int __init sleep_init(void)
194194
our_proc_file =
195195
proc_create(PROC_ENTRY_FILENAME, 0644, NULL, &file_ops_4_our_proc_file);
196196
if (our_proc_file == NULL) {
197-
remove_proc_entry(PROC_ENTRY_FILENAME, NULL);
198197
pr_debug("Error: Could not initialize /proc/%s\n", PROC_ENTRY_FILENAME);
199198
return -ENOMEM;
200199
}

0 commit comments

Comments
 (0)