Skip to content

Commit 470fbcd

Browse files
authored
Fix switch-case condition error in sample code (#245)
The code 'case -EINPROGRESS || -EBUSY: ' is the same as 'case -115 || -16 :' at compiler time, as both error code are implemented with macro like '#define EBUSY 16'. The code above is essentially the same as 'case 1:'. In C, there is no real boolean value. Boolean-like value will be converted to 1 or 0. It does not matter too much if the '-EINPROGRESS || -EBUSY' is calculated at build time or at runtime. In both case, it will compare the 'rc' with 1 in the switch expression. It will not compare the 'rc' with any real error code number. When the code is really '-EBUSY', the execution will fallback to the default branch. And in practice, most of the compilers will do this simple compile-time static calculation, and generate code like static int test_skcipher_result(struct skcipher_def *sk, int rc) { switch (rc) { case 0: break; case 1: rc = wait_for_completion_interruptible(&sk->result.completion); /* code removed for conciseness */ break; default: pr_info("skcipher encrypt returned with %d result %d\n", rc, sk->result.err); break; } init_completion(&sk->result.completion); return rc; }
1 parent 391f111 commit 470fbcd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

examples/cryptosk.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ static int test_skcipher_result(struct skcipher_def *sk, int rc)
4646
switch (rc) {
4747
case 0:
4848
break;
49-
case -EINPROGRESS || -EBUSY:
49+
case -EINPROGRESS:
50+
case -EBUSY:
5051
rc = wait_for_completion_interruptible(&sk->result.completion);
5152
if (!rc && !sk->result.err) {
5253
reinit_completion(&sk->result.completion);

0 commit comments

Comments
 (0)