Skip to content

Commit 170dfac

Browse files
committed
Review request: added quotes and exit with error if invalid links found
Signed-off-by: mrgarris0n <gergely.karacsonyi@gmail.com>
1 parent 6777cac commit 170dfac

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

_tools/linkcheck

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ check_urls()
1313
{
1414
echo "Checking validity of external links..."
1515

16-
local URLS+=($(grep 'url:' $EXTERNAL_LINK_FILE | tail -n+1 | awk '{ print $2}'))
16+
local URLS+=($(grep 'url:' "$EXTERNAL_LINK_FILE" | tail -n+1 | awk '{ print $2}'))
1717

1818
if [ ${#URLS[@]} == 0 ]; then
1919
echo "No links found in $EXTERNAL_LINK_FILE, please check."
@@ -36,6 +36,7 @@ check_urls()
3636
echo "Every link is alive and OK."
3737
else
3838
echo "$INVALID invalid links found."
39+
exit 1
3940
fi
4041
}
4142

0 commit comments

Comments
 (0)