Use all_subscription_ids flags instead of subscription_ids as this variable is always populated for each management group while the other is not (#54)

miguelpais · web-flow · commit fe6b782cc8e2 · 2024-08-29T16:59:51.000+02:00
diff --git a/modules/agentless-scanning/organizational.tf b/modules/agentless-scanning/organizational.tf
@@ -13,8 +13,8 @@ data "azurerm_management_group" "management_groups" {
 }
 
 locals {
-  subscriptions = toset(var.is_organizational && length(var.management_group_ids) == 0 ? data.azurerm_management_group.root_management_group[0].subscription_ids :
-  flatten([for m in data.azurerm_management_group.management_groups : m.subscription_ids]))
+  subscriptions = toset(var.is_organizational && length(var.management_group_ids) == 0 ? data.azurerm_management_group.root_management_group[0].all_subscription_ids :
+  flatten([for m in data.azurerm_management_group.management_groups : m.all_subscription_ids]))
 }
 
 resource "azurerm_lighthouse_assignment" "lighthouse_assignment_for_tenant" {

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,8 @@ data "azurerm_management_group" "management_groups" {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`locals {`
`16`		`- subscriptions = toset(var.is_organizational && length(var.management_group_ids) == 0 ? data.azurerm_management_group.root_management_group[0].subscription_ids :`
`17`		`- flatten([for m in data.azurerm_management_group.management_groups : m.subscription_ids]))`
	`16`	`+ subscriptions = toset(var.is_organizational && length(var.management_group_ids) == 0 ? data.azurerm_management_group.root_management_group[0].all_subscription_ids :`
	`17`	`+ flatten([for m in data.azurerm_management_group.management_groups : m.all_subscription_ids]))`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`resource "azurerm_lighthouse_assignment" "lighthouse_assignment_for_tenant" {`