Skip to content

Commit f2bf94f

Browse files
author
iru
authored
docs: clarify ecr in org-management account
1 parent eae5447 commit f2bf94f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ If you're unsure about what/how to use this module, please fill the [questionnai
4343
* [AWS regions](https://docs.aws.amazon.com/general/latest/gr/rande.html#regional-endpoints)
4444
* **Resource creation inventory** Find all the resources created by Sysdig examples in the resource-group `sysdig-secure-for-cloud` (AWS Resource Group & Tag Editor) <br/>
4545
* All Sysdig Secure for Cloud features but [Image Scanning](https://docs.sysdig.com/en/docs/sysdig-secure/scanning/) are enabled by default. You can enable it through `deploy_scanning` input variable parameters.<br/>
46-
- **Management Account ECR image scanning** is not support since it's [not a best practies](https://docs.aws.amazon.com/organizations/latest/userguide/orgs_best-practices_mgmt-acct.html#best-practices_mgmt-use) to have an ECR in the management account. However, we have a workaround to [solve this problem](#q-scanning-images-pushed-to-management-account-ecr-are-not-scanned) in case you need to scan images pushed to the management account ECR.
46+
- **Management Account ECR image scanning** is not support since it's [not a best practice](https://docs.aws.amazon.com/organizations/latest/userguide/orgs_best-practices_mgmt-acct.html#best-practices_mgmt-use) to have an ECR in the management account. However, we have a workaround to [solve this problem](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud#q-aws-scanning-images-pushed-to-management-account-ecr-are-not-scanned) in case you need to scan images pushed to the management account ECR.
4747
* **Deployment cost** This example will create resources that cost money.<br/>Run `terraform destroy` when you don't need them anymore
4848
* For **free subscription** users, beware that organizational examples may not deploy properly due to the [1 cloud-account limitation](https://docs.sysdig.com/en/docs/administration/administration-settings/subscription/#cloud-billing-free-tier). Open an Issue so we can help you here!
4949

@@ -210,7 +210,7 @@ A: Need to check several steps
210210
<br/>If previous logs are ok, check [spawned scanning service](http://localhost:1313/en/docs/sysdig-secure/sysdig-secure-for-cloud/#summary) logs
211211
212212
### Q-AWS-Scanning: Images pushed to Management Account ECR are not scanned
213-
A: We don’t scan images from the management account ECR because is not a best practies to have an ECR in this account.
213+
A: We don’t scan images from the management account ECR because is [not a best pratice](https://docs.aws.amazon.com/organizations/latest/userguide/orgs_best-practices_mgmt-acct.html#best-practices_mgmt-use) to have an ECR in this account.
214214
</br>S: Following Role has to be created in the management account
215215
- Role Name: **OrganizationAccountAccessRole**
216216
- Permissions Policies:
@@ -235,7 +235,7 @@ A: We don’t scan images from the management account ECR because is not a best
235235
{
236236
"Effect": "Allow",
237237
"Principal": {
238-
"AWS": "arn:aws:iam::<<managementAccountID>>:root"
238+
"AWS": "arn:aws:iam::<ORG_MANAGEMENT_ACCOUNT_ID>:root"
239239
},
240240
"Action": "sts:AssumeRole"
241241
}

0 commit comments

Comments
 (0)