feat(bench) adding random schedule for benchmark tasks (#47)

* adding random schedule for benchmark tasks

* chore: docs/lint

* chore: remove kitchen tf version verif

Co-authored-by: iru <irune.prado@sysdig.com>

Author: sameer-in

.kitchen.yml

@@ -3,6 +3,7 @@ driver:
   name: terraform
   root_module_directory: test/fixtures
   parallelism: 4
+  verify_version: false
 
 provisioner:
   name: terraform

examples/organizational/README.md

@@ -24,7 +24,7 @@ Minimum requirements:
       > You must be logged in with the management account for the organization to create an organization trail. You must also have sufficient permissions for the IAM user or role in the management account to successfully create an organization trail.
     * When an account is created within an organization, AWS will create an `OrganizationAccountAccessRole` [for account management](https://docs.aws.amazon.com/organizations/latest/userguide/orgs_manage_accounts_access.html), which Sysdig Secure for Cloud will use for member-account provisioning and role assuming.
     * However, when the account is invited into the organization, it's required to [create the role manually](https://docs.aws.amazon.com/organizations/latest/userguide/orgs_manage_accounts_access.html#orgs_manage_accounts_create-cross-account-role)
-       > You have to do this manually, as shown in the following procedure. This essentially duplicates the role automatically set up for created accounts. We recommend that you use the same name, OrganizationAccountAccessRole, for your manually created roles for consistency and ease of remembering. 
+       > You have to do this manually, as shown in the following procedure. This essentially duplicates the role automatically set up for created accounts. We recommend that you use the same name, OrganizationAccountAccessRole, for your manually created roles for consistency and ease of remembering.
     * This role name, `OrganizationAccountAccessRole`, is currently hardcoded on the module.
 3. Provide a member **account ID for Sysdig Secure for Cloud workload** to be deployed.
    Our recommendation is for this account to be empty, so that deployed resources are not mixed up with your workload.

modules/services/cloud-bench/README.md

@@ -14,13 +14,15 @@ Deploys
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.15.0 |
 | <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.62.0 |
+| <a name="requirement_random"></a> [random](#requirement\_random) | >= 3.1.0 |
 | <a name="requirement_sysdig"></a> [sysdig](#requirement\_sysdig) | >= 0.5.21 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
 | <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.62.0 |
+| <a name="provider_random"></a> [random](#provider\_random) | >= 3.1.0 |
 | <a name="provider_sysdig"></a> [sysdig](#provider\_sysdig) | >= 0.5.21 |
 
 ## Modules
@@ -35,6 +37,8 @@ No modules.
 | [aws_cloudformation_stack_set_instance.stackset_instance](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudformation_stack_set_instance) | resource |
 | [aws_iam_role.cloudbench_role](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
 | [aws_iam_role_policy_attachment.cloudbench_security_audit](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
+| [random_integer.hour](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/integer) | resource |
+| [random_integer.minute](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/integer) | resource |
 | [sysdig_secure_benchmark_task.benchmark_task](https://registry.terraform.io/providers/sysdiglabs/sysdig/latest/docs/resources/secure_benchmark_task) | resource |
 | [sysdig_secure_cloud_account.cloud_account](https://registry.terraform.io/providers/sysdiglabs/sysdig/latest/docs/resources/secure_cloud_account) | resource |
 | [aws_caller_identity.me](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/caller_identity) | data source |

modules/services/cloud-bench/main.tf

@@ -40,9 +40,19 @@ locals {
   )
 }
 
+resource "random_integer" "minute" {
+  max = 59
+  min = 0
+}
+
+resource "random_integer" "hour" {
+  max = 23
+  min = 0
+}
+
 resource "sysdig_secure_benchmark_task" "benchmark_task" {
   name     = "Sysdig Secure for Cloud (AWS) - ${local.benchmark_task_name}"
-  schedule = "0 6 * * *"
+  schedule = "${random_integer.minute.result} ${random_integer.hour.result} * * *"
   schema   = "aws_foundations_bench-1.3.0"
   scope    = "${local.accounts_scope_clause}${local.regions_scope_clause}"
 

modules/services/cloud-bench/versions.tf

@@ -1,6 +1,11 @@
 terraform {
   required_version = ">= 0.15.0"
   required_providers {
+    random = {
+      source  = "hashicorp/random"
+      version = ">= 3.1.0"
+    }
+
     aws = {
       version = ">= 3.62.0"
     }