Skip to content

Commit c6051a2

Browse files
committed
ci: remove job execution on macos
We don't expect people running the GH Action on MacOS machines. Even the concept of creating an OCI image exclusively for MacOS doesn't make so much sense, the OCI images running on the Apple's OS are mostly Linux images.
1 parent c0ca3fa commit c6051a2

File tree

2 files changed

+1
-62
lines changed

2 files changed

+1
-62
lines changed

.github/workflows/ci-scan.yaml

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -77,41 +77,6 @@ jobs:
7777
echo "Scan failed as expected."
7878
fi
7979
80-
macos-scan-from-registry:
81-
runs-on: macos-latest
82-
83-
steps:
84-
# This step checks out a copy of your repository.
85-
- name: Check out repository
86-
uses: actions/checkout@v4
87-
88-
- name: Scan dummy-vuln-app from registry
89-
id: scan
90-
uses: ./
91-
continue-on-error: true
92-
with:
93-
# Tag of the image to analyse
94-
image-tag: sysdiglabs/dummy-vuln-app:latest
95-
# API token for Sysdig Scanning auth
96-
sysdig-secure-token: ${{ secrets.KUBELAB_SECURE_API_TOKEN }}
97-
stop-on-failed-policy-eval: true
98-
stop-on-processing-error: true
99-
100-
- name: Upload SARIF file
101-
if: success() || failure() # Upload results regardless previous step fails
102-
uses: github/codeql-action/upload-sarif@v3
103-
with:
104-
sarif_file: ${{ github.workspace }}/sarif.json
105-
106-
- name: Check that the scan has failed
107-
run: |
108-
if [ "${{ steps.scan.outcome }}" == "success" ]; then
109-
echo "Scan succeeded but the step should fail."
110-
exit 1
111-
else
112-
echo "Scan failed as expected."
113-
fi
114-
11580
standalone-scan-from-registry:
11681
runs-on: ubuntu-latest
11782

.github/workflows/scan.yaml

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -57,32 +57,6 @@ jobs:
5757
with:
5858
sarif_file: ${{ github.workspace }}/sarif.json
5959

60-
macos-scan-from-registry:
61-
runs-on: macos-latest
62-
63-
steps:
64-
# This step checks out a copy of your repository.
65-
- name: Check out repository
66-
uses: actions/checkout@v4
67-
68-
- name: Scan dummy-vuln-app from registry
69-
id: scan
70-
uses: ./
71-
with:
72-
# Tag of the image to analyse
73-
image-tag: sysdiglabs/dummy-vuln-app:latest
74-
# API token for Sysdig Scanning auth
75-
sysdig-secure-token: ${{ secrets.KUBELAB_SECURE_API_TOKEN }}
76-
stop-on-failed-policy-eval: true
77-
stop-on-processing-error: true
78-
79-
- name: Upload SARIF file
80-
if: success() || failure() # Upload results regardless previous step fails
81-
uses: github/codeql-action/upload-sarif@v3
82-
with:
83-
sarif_file: ${{ github.workspace }}/sarif.json
84-
85-
8660
standalone-scan-from-registry:
8761
runs-on: ubuntu-latest
8862

@@ -119,4 +93,4 @@ jobs:
11993
if: success() || failure() # Upload results regardless previous step fails
12094
uses: github/codeql-action/upload-sarif@v3
12195
with:
122-
sarif_file: ${{ github.workspace }}/sarif.json
96+
sarif_file: ${{ github.workspace }}/sarif.json

0 commit comments

Comments
 (0)