Skip to content

Commit 01a23fc

Browse files
committed
Refactor ILM collector
Consolidate the ILM collector logic into a single collector using the new Collector interface Signed-off-by: Joe Adams <github@joeadams.io>
1 parent 03063c8 commit 01a23fc

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,20 @@
33
BREAKING CHANGES:
44

55
The flag `--es.data_stream` has been renamed to `--collector.data-stream`.
6+
The flag `--es.ilm` has been renamed to `--collector.ilm`.
67

78
* [CHANGE] Rename --es.data_stream to --collector.data-stream #983
9+
* [CHANGE] Rename --es.ilm to --collector.ilm #999
810

911
## 1.9.0 / 2025-02-27
1012

1113
BREAKING CHANGES:
1214

1315
The flag `--es.slm` has been renamed to `--collector.slm`.
14-
The flag `--es.ilm` has been renamed to `--collector.ilm`.
1516

1617
The logging system has been replaced with log/slog from the stdlib. This change is being made across the prometheus ecosystem. The logging output has changed, but the messages and levels remain the same. The `ts` label for the timestamp has bewen replaced with `time`, the accuracy is less, and the timezone is not forced to UTC. The `caller` field has been replaced by the `source` field, which now includes the full path to the source file. The `level` field now exposes the log level in capital letters.
1718

1819
* [CHANGE] Rename --es.slm to --collector.slm #932
19-
* [CHANGE] Rename --es.ilm to --collector.ilm #XXX
2020
* [CHANGE] Replace logging system #942
2121
* [ENHANCEMENT] Add external refresh stats #933
2222

collector/ilm.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ var (
3434

3535
ilmStatus = prometheus.NewDesc(
3636
prometheus.BuildFQName(namespace, "ilm", "status"),
37-
"Current status of ilm. Status can be STOPPED, RUNNING, STOPPING.",
37+
"Current status of ILM. Status can be STOPPED, RUNNING, STOPPING.",
3838
[]string{"operation_mode"}, nil,
3939
)
4040
)

collector/ilm_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func TestILM(t *testing.T) {
4141
# TYPE elasticsearch_ilm_index_status gauge
4242
elasticsearch_ilm_index_status{action="",index="twitter",phase="",step=""} 0
4343
elasticsearch_ilm_index_status{action="complete",index="facebook",phase="new",step="complete"} 1
44-
# HELP elasticsearch_ilm_status Current status of ilm. Status can be STOPPED, RUNNING, STOPPING.
44+
# HELP elasticsearch_ilm_status Current status of ILM. Status can be STOPPED, RUNNING, STOPPING.
4545
# TYPE elasticsearch_ilm_status gauge
4646
elasticsearch_ilm_status{operation_mode="RUNNING"} 1
4747
elasticsearch_ilm_status{operation_mode="STOPPED"} 0

0 commit comments

Comments
 (0)