Merge branch '5.4' into 6.4

* 5.4:
  fix tests using Twig 3.12
  skip tests requiring the intl extension if it's not installed
  🐛 throw ParseException on invalid date
  [ExpressionLanguage] Improve test coverage
  [HttpKernel] [WebProfileBundle] Fix Routing panel for URLs with a colon
  [Form] NumberType: Fix parsing of numbers in exponential notation with negative exponent
  [Security] consistent singular/plural translation in Dutch
  reset the validation context after validating nested constraints
  do not duplicate directory separators
  fix handling empty data in ValueToDuplicatesTransformer
  [Validator] review latvian translations
  [Validator] Add Dutch translation for `WordCount` constraint
  allow more unicode characters in URL paths
  [String][EnglishInflector] Fix words ending in 'le', e.g., articles
  do not duplicate directory separators
  [Uid] Ensure UuidV1 is created in lowercase

Author: derrabus

src/Symfony/Bridge/Twig/Tests/Extension/HttpKernelExtensionTest.php

@@ -71,7 +71,7 @@ public function testGenerateFragmentUri()
             'index' => sprintf(<<<TWIG
 {{ fragment_uri(controller("%s::templateAction", {template: "foo.html.twig"})) }}
 TWIG
-                , TemplateController::class), ]);
+                , str_replace('\\', '\\\\', TemplateController::class)), ]);
         $twig = new Environment($loader, ['debug' => true, 'cache' => false]);
         $twig->addExtension(new HttpKernelExtension());
 
@@ -81,7 +81,7 @@ public function testGenerateFragmentUri()
         ]);
         $twig->addRuntimeLoader($loader);
 
-        $this->assertSame('/_fragment?_hash=PP8%2FeEbn1pr27I9wmag%2FM6jYGVwUZ0l2h0vhh2OJ6CI%3D&amp;_path=template%3Dfoo.html.twig%26_format%3Dhtml%26_locale%3Den%26_controller%3DSymfonyBundleFrameworkBundleControllerTemplateController%253A%253AtemplateAction', $twig->render('index'));
+        $this->assertSame('/_fragment?_hash=XCg0hX8QzSwik8Xuu9aMXhoCeI4oJOob7lUVacyOtyY%3D&amp;_path=template%3Dfoo.html.twig%26_format%3Dhtml%26_locale%3Den%26_controller%3DSymfony%255CBundle%255CFrameworkBundle%255CController%255CTemplateController%253A%253AtemplateAction', $twig->render('index'));
     }
 
     protected function getFragmentHandler($returnOrException): FragmentHandler

src/Symfony/Bundle/WebProfilerBundle/Controller/RouterController.php

@@ -83,10 +83,10 @@ public function panelAction(string $token): Response
      */
     private function getTraces(RequestDataCollector $request, string $method): array
     {
-        $traceRequest = Request::create(
-            $request->getPathInfo(),
-            $request->getRequestServer(true)->get('REQUEST_METHOD'),
-            \in_array($request->getMethod(), ['DELETE', 'PATCH', 'POST', 'PUT'], true) ? $request->getRequestRequest()->all() : $request->getRequestQuery()->all(),
+        $traceRequest = new Request(
+            $request->getRequestQuery()->all(),
+            $request->getRequestRequest()->all(),
+            $request->getRequestAttributes()->all(),
             $request->getRequestCookies(true)->all(),
             [],
             $request->getRequestServer(true)->all()

src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/RouterControllerTest.php

@@ -0,0 +1,48 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\WebProfilerBundle\Tests\Controller;
+
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+use Symfony\Bundle\FrameworkBundle\Routing\Router;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Bundle\WebProfilerBundle\Tests\Functional\WebProfilerBundleKernel;
+use Symfony\Component\DomCrawler\Crawler;
+use Symfony\Component\Routing\Route;
+
+class RouterControllerTest extends WebTestCase
+{
+    public function testFalseNegativeTrace()
+    {
+        $path = '/foo/bar:123/baz';
+
+        $kernel = new WebProfilerBundleKernel();
+        $client = new KernelBrowser($kernel);
+        $client->disableReboot();
+        $client->getKernel()->boot();
+
+        /** @var Router $router */
+        $router = $client->getContainer()->get('router');
+        $router->getRouteCollection()->add('route1', new Route($path));
+
+        $client->request('GET', $path);
+
+        $crawler = $client->request('GET', '/_profiler/latest?panel=router&type=request');
+
+        $matchedRouteCell = $crawler
+            ->filter('#router-logs .status-success td')
+            ->reduce(function (Crawler $td) use ($path): bool {
+                return $td->text() === $path;
+            });
+
+        $this->assertSame(1, $matchedRouteCell->count());
+    }
+}

src/Symfony/Component/ExpressionLanguage/Tests/ExpressionLanguageTest.php

@@ -460,4 +460,11 @@ function (ExpressionLanguage $el) {
             ],
         ];
     }
+
+    public function testParseAlreadyParsedExpressionReturnsSameObject()
+    {
+        $el = new ExpressionLanguage();
+        $parsed = $el->parse('1 + 1', []);
+        $this->assertSame($parsed, $el->parse($parsed, []));
+    }
 }

src/Symfony/Component/ExpressionLanguage/Tests/Node/BinaryNodeTest.php

@@ -218,6 +218,26 @@ public function testCompileMatchesWithInvalidRegexpAsExpression()
         eval('$regexp = "this is not a regexp"; '.$compiler->getSource().';');
     }
 
+    public function testDivisionByZero()
+    {
+        $node = new BinaryNode('/', new ConstantNode(1), new ConstantNode(0));
+
+        $this->expectException(\DivisionByZeroError::class);
+        $this->expectExceptionMessage('Division by zero.');
+
+        $node->evaluate([], []);
+    }
+
+    public function testModuloByZero()
+    {
+        $node = new BinaryNode('%', new ConstantNode(1), new ConstantNode(0));
+
+        $this->expectException(\DivisionByZeroError::class);
+        $this->expectExceptionMessage('Modulo by zero.');
+
+        $node->evaluate([], []);
+    }
+
     /**
      * @group legacy
      */

src/Symfony/Component/ExpressionLanguage/Tests/Node/NodeTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\ExpressionLanguage\Tests\Node;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\ExpressionLanguage\Compiler;
 use Symfony\Component\ExpressionLanguage\Node\ConstantNode;
 use Symfony\Component\ExpressionLanguage\Node\Node;
 
@@ -38,4 +39,33 @@ public function testSerialization()
 
         $this->assertEquals($node, $unserializedNode);
     }
+
+    public function testCompileActuallyCompilesAllNodes()
+    {
+        $nodes = [];
+        foreach (range(1, 10) as $ignored) {
+            $node = $this->createMock(Node::class);
+            $node->expects($this->once())->method('compile');
+
+            $nodes[] = $node;
+        }
+
+        $node = new Node($nodes);
+        $node->compile($this->createMock(Compiler::class));
+    }
+
+    public function testEvaluateActuallyEvaluatesAllNodes()
+    {
+        $nodes = [];
+        foreach (range(1, 3) as $i) {
+            $node = $this->createMock(Node::class);
+            $node->expects($this->once())->method('evaluate')
+                ->willReturn($i);
+
+            $nodes[] = $node;
+        }
+
+        $node = new Node($nodes);
+        $this->assertSame([1, 2, 3], $node->evaluate([], []));
+    }
 }

src/Symfony/Component/ExpressionLanguage/Tests/ParserTest.php

@@ -37,6 +37,17 @@ public function testParseWithZeroInNames()
         $parser->parse($lexer->tokenize('foo'), [0]);
     }
 
+    public function testParsePrimaryExpressionWithUnknownFunctionThrows()
+    {
+        $parser = new Parser([]);
+        $stream = (new Lexer())->tokenize('foo()');
+
+        $this->expectException(SyntaxError::class);
+        $this->expectExceptionMessage('The function "foo" does not exist around position 1 for expression `foo()`.');
+
+        $parser->parse($stream);
+    }
+
     /**
      * @dataProvider getParseData
      */

src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php

@@ -63,8 +63,9 @@ public function current(): SplFileInfo
             $subPathname .= $this->directorySeparator;
         }
         $subPathname .= $this->getFilename();
+        $basePath = $this->rootPath;
 
-        if ('/' !== $basePath = $this->rootPath) {
+        if ('/' !== $basePath && !str_ends_with($basePath, $this->directorySeparator) && !str_ends_with($basePath, '/')) {
             $basePath .= $this->directorySeparator;
         }
 

src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php

@@ -55,4 +55,31 @@ public function testSeekOnFtp()
 
         $this->assertEquals($contains, $actual);
     }
+
+    public function testTrailingDirectorySeparatorIsStripped()
+    {
+        $fixturesDirectory = __DIR__ . '/../Fixtures/';
+        $actual = [];
+
+        foreach (new RecursiveDirectoryIterator($fixturesDirectory, RecursiveDirectoryIterator::SKIP_DOTS) as $file) {
+            $actual[] = $file->getPathname();
+        }
+
+        sort($actual);
+
+        $expected = [
+            $fixturesDirectory.'.dot',
+            $fixturesDirectory.'A',
+            $fixturesDirectory.'copy',
+            $fixturesDirectory.'dolor.txt',
+            $fixturesDirectory.'gitignore',
+            $fixturesDirectory.'ipsum.txt',
+            $fixturesDirectory.'lorem.txt',
+            $fixturesDirectory.'one',
+            $fixturesDirectory.'r+e.gex[c]a(r)s',
+            $fixturesDirectory.'with space',
+        ];
+
+        $this->assertEquals($expected, $actual);
+    }
 }

src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php

@@ -106,7 +106,8 @@ public function reverseTransform(mixed $value): int|float|null
             $value = str_replace(',', $decSep, $value);
         }
 
-        if (str_contains($value, $decSep)) {
+        //If the value is in exponential notation with a negative exponent, we end up with a float value too
+        if (str_contains($value, $decSep) || false !== stripos($value, 'e-')) {
             $type = \NumberFormatter::TYPE_DOUBLE;
         } else {
             $type = \PHP_INT_SIZE === 8