Skip to content

Commit 8a2c97b

Browse files
minor symfony#58625 [HttpClient] Fix typo in deprecation message (Seldaek)
This PR was merged into the 7.1 branch. Discussion ---------- [HttpClient] Fix typo in deprecation message | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Just a typo fix from symfony#54806 This confused me initially because I thought I had to configure it on a wrapper, so add one more layer, but couldn't find a logging wrapper client.. Anyway `@xabbuh` one more question do I understand it correctly that if one just uses autowiring and the framework.http_client config to create a client, then the loggers will be set by default and nothing has to be done? No need to call setLogger explicitly on the client right? Commits ------- 648e531 Fix typo in deprecation message
2 parents d05ed96 + 648e531 commit 8a2c97b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/Symfony/Component/HttpClient/NoPrivateNetworkHttpClient.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ public function stream(ResponseInterface|iterable $responses, ?float $timeout =
7878
}
7979

8080
/**
81-
* @deprecated since Symfony 7.1, configure the logger on the wrapper HTTP client directly instead
81+
* @deprecated since Symfony 7.1, configure the logger on the wrapped HTTP client directly instead
8282
*/
8383
public function setLogger(LoggerInterface $logger): void
8484
{
85-
trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapper HTTP client directly instead.');
85+
trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapped HTTP client directly instead.');
8686

8787
if ($this->client instanceof LoggerAwareInterface) {
8888
$this->client->setLogger($logger);

src/Symfony/Component/HttpClient/ScopingHttpClient.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,11 @@ public function reset(): void
101101
}
102102

103103
/**
104-
* @deprecated since Symfony 7.1, configure the logger on the wrapper HTTP client directly instead
104+
* @deprecated since Symfony 7.1, configure the logger on the wrapped HTTP client directly instead
105105
*/
106106
public function setLogger(LoggerInterface $logger): void
107107
{
108-
trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapper HTTP client directly instead.');
108+
trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapped HTTP client directly instead.');
109109

110110
if ($this->client instanceof LoggerAwareInterface) {
111111
$this->client->setLogger($logger);

src/Symfony/Component/HttpClient/TraceableHttpClient.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,11 @@ public function reset(): void
9090
}
9191

9292
/**
93-
* @deprecated since Symfony 7.1, configure the logger on the wrapper HTTP client directly instead
93+
* @deprecated since Symfony 7.1, configure the logger on the wrapped HTTP client directly instead
9494
*/
9595
public function setLogger(LoggerInterface $logger): void
9696
{
97-
trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapper HTTP client directly instead.');
97+
trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapped HTTP client directly instead.');
9898

9999
if ($this->client instanceof LoggerAwareInterface) {
100100
$this->client->setLogger($logger);

0 commit comments

Comments
 (0)