[Cache] Fix possibly null value passed to preg_match() in RedisTrait

chalasr · chalasr · commit 89e6c2f0b58e · 2022-12-29T17:06:09.000+01:00
diff --git a/src/Symfony/Component/Cache/Traits/RedisTrait.php b/src/Symfony/Component/Cache/Traits/RedisTrait.php
@@ -237,7 +237,7 @@ public static function createConnection(string $dsn, array $options = [])
                         restore_error_handler();
                     }
                     if (!$isConnected) {
-                        $error = preg_match('/^Redis::p?connect\(\): (.*)/', $error, $error) ? sprintf(' (%s)', $error[1]) : '';
+                        $error = preg_match('/^Redis::p?connect\(\): (.*)/', $error ?? '', $error) ? sprintf(' (%s)', $error[1]) : '';
                         throw new InvalidArgumentException(sprintf('Redis connection "%s" failed: ', $dsn).$error.'.');
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ public static function createConnection(string $dsn, array $options = [])`
`237`	`237`	`restore_error_handler();`
`238`	`238`	`}`
`239`	`239`	`if (!$isConnected) {`
`240`		`- $error = preg_match('/^Redis::p?connect\(\): (.*)/', $error, $error) ? sprintf(' (%s)', $error[1]) : '';`
	`240`	`+ $error = preg_match('/^Redis::p?connect\(\): (.*)/', $error ?? '', $error) ? sprintf(' (%s)', $error[1]) : '';`
`241`	`241`	`throw new InvalidArgumentException(sprintf('Redis connection "%s" failed: ', $dsn).$error.'.');`
`242`	`242`	`}`
`243`	`243`