minor symfony#57329 [DependencyInjection][DomCrawler][ExpressionLanguage][Serializer][VarDumper][Workflow] use constructor property promotion (xabbuh)

This PR was merged into the 7.2 branch.

Discussion
----------

[DependencyInjection][DomCrawler][ExpressionLanguage][Serializer][VarDumper][Workflow] use constructor property promotion

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

f184ada use constructor property promotion

Author: fabpot

src/Symfony/Component/DependencyInjection/Alias.php

@@ -17,14 +17,12 @@ class Alias
 {
     private const DEFAULT_DEPRECATION_TEMPLATE = 'The "%alias_id%" service alias is deprecated. You should stop using it, as it will be removed in the future.';
 
-    private string $id;
-    private bool $public;
     private array $deprecation = [];
 
-    public function __construct(string $id, bool $public = false)
-    {
-        $this->id = $id;
-        $this->public = $public;
+    public function __construct(
+        private string $id,
+        private bool $public = false,
+    ) {
     }
 
     /**

src/Symfony/Component/DependencyInjection/Argument/BoundArgument.php

@@ -22,22 +22,20 @@ final class BoundArgument implements ArgumentInterface
 
     private static int $sequence = 0;
 
-    private mixed $value;
     private ?int $identifier = null;
     private ?bool $used = null;
-    private int $type;
-    private ?string $file;
 
-    public function __construct(mixed $value, bool $trackUsage = true, int $type = 0, ?string $file = null)
-    {
-        $this->value = $value;
+    public function __construct(
+        private mixed $value,
+        bool $trackUsage = true,
+        private int $type = 0,
+        private ?string $file = null,
+    ) {
         if ($trackUsage) {
             $this->identifier = ++self::$sequence;
         } else {
             $this->used = true;
         }
-        $this->type = $type;
-        $this->file = $file;
     }
 
     public function getValues(): array

src/Symfony/Component/DependencyInjection/Argument/ServiceLocator.php

@@ -20,15 +20,11 @@
  */
 class ServiceLocator extends BaseServiceLocator
 {
-    private \Closure $factory;
-    private array $serviceMap;
-    private ?array $serviceTypes;
-
-    public function __construct(\Closure $factory, array $serviceMap, ?array $serviceTypes = null)
-    {
-        $this->factory = $factory;
-        $this->serviceMap = $serviceMap;
-        $this->serviceTypes = $serviceTypes;
+    public function __construct(
+        private \Closure $factory,
+        private array $serviceMap,
+        private ?array $serviceTypes = null,
+    ) {
         parent::__construct($serviceMap);
     }
 

src/Symfony/Component/DependencyInjection/Argument/TaggedIteratorArgument.php

@@ -18,13 +18,9 @@
  */
 class TaggedIteratorArgument extends IteratorArgument
 {
-    private string $tag;
     private mixed $indexAttribute;
     private ?string $defaultIndexMethod;
     private ?string $defaultPriorityMethod;
-    private bool $needsIndexes;
-    private array $exclude;
-    private bool $excludeSelf = true;
 
     /**
      * @param string      $tag                   The name of the tag identifying the target services
@@ -35,21 +31,24 @@ class TaggedIteratorArgument extends IteratorArgument
      * @param array       $exclude               Services to exclude from the iterator
      * @param bool        $excludeSelf           Whether to automatically exclude the referencing service from the iterator
      */
-    public function __construct(string $tag, ?string $indexAttribute = null, ?string $defaultIndexMethod = null, bool $needsIndexes = false, ?string $defaultPriorityMethod = null, array $exclude = [], bool $excludeSelf = true)
-    {
+    public function __construct(
+        private string $tag,
+        ?string $indexAttribute = null,
+        ?string $defaultIndexMethod = null,
+        private bool $needsIndexes = false,
+        ?string $defaultPriorityMethod = null,
+        private array $exclude = [],
+        private bool $excludeSelf = true,
+    ) {
         parent::__construct([]);
 
         if (null === $indexAttribute && $needsIndexes) {
             $indexAttribute = preg_match('/[^.]++$/', $tag, $m) ? $m[0] : $tag;
         }
 
-        $this->tag = $tag;
         $this->indexAttribute = $indexAttribute;
         $this->defaultIndexMethod = $defaultIndexMethod ?: ($indexAttribute ? 'getDefault'.str_replace(' ', '', ucwords(preg_replace('/[^a-zA-Z0-9\x7f-\xff]++/', ' ', $indexAttribute))).'Name' : null);
-        $this->needsIndexes = $needsIndexes;
         $this->defaultPriorityMethod = $defaultPriorityMethod ?: ($indexAttribute ? 'getDefault'.str_replace(' ', '', ucwords(preg_replace('/[^a-zA-Z0-9\x7f-\xff]++/', ' ', $indexAttribute))).'Priority' : null);
-        $this->exclude = $exclude;
-        $this->excludeSelf = $excludeSelf;
     }
 
     public function getTag(): string

src/Symfony/Component/DependencyInjection/ChildDefinition.php

@@ -21,14 +21,12 @@
  */
 class ChildDefinition extends Definition
 {
-    private string $parent;
-
     /**
      * @param string $parent The id of Definition instance to decorate
      */
-    public function __construct(string $parent)
-    {
-        $this->parent = $parent;
+    public function __construct(
+        private string $parent,
+    ) {
     }
 
     /**

src/Symfony/Component/DependencyInjection/Compiler/AnalyzeServiceReferencesPass.php

@@ -36,8 +36,6 @@ class AnalyzeServiceReferencesPass extends AbstractRecursivePass
 
     private ServiceReferenceGraph $graph;
     private ?Definition $currentDefinition = null;
-    private bool $onlyConstructorArguments;
-    private bool $hasProxyDumper;
     private bool $lazy;
     private bool $byConstructor;
     private bool $byFactory;
@@ -47,10 +45,10 @@ class AnalyzeServiceReferencesPass extends AbstractRecursivePass
     /**
      * @param bool $onlyConstructorArguments Sets this Service Reference pass to ignore method calls
      */
-    public function __construct(bool $onlyConstructorArguments = false, bool $hasProxyDumper = true)
-    {
-        $this->onlyConstructorArguments = $onlyConstructorArguments;
-        $this->hasProxyDumper = $hasProxyDumper;
+    public function __construct(
+        private bool $onlyConstructorArguments = false,
+        private bool $hasProxyDumper = true,
+    ) {
         $this->enableExpressionProcessing();
     }
 

src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php

@@ -41,16 +41,15 @@ class AutowirePass extends AbstractRecursivePass
     private array $ambiguousServiceTypes;
     private array $autowiringAliases;
     private ?string $lastFailure = null;
-    private bool $throwOnAutowiringException;
     private ?string $decoratedClass = null;
     private ?string $decoratedId = null;
     private object $defaultArgument;
     private ?\Closure $restorePreviousValue = null;
     private ?self $typesClone = null;
 
-    public function __construct(bool $throwOnAutowireException = true)
-    {
-        $this->throwOnAutowiringException = $throwOnAutowireException;
+    public function __construct(
+        private bool $throwOnAutowiringException = true,
+    ) {
         $this->defaultArgument = new class() {
             public $value;
             public $names;

src/Symfony/Component/DependencyInjection/Compiler/CheckArgumentsValidityPass.php

@@ -24,11 +24,9 @@ class CheckArgumentsValidityPass extends AbstractRecursivePass
 {
     protected bool $skipScalars = true;
 
-    private bool $throwExceptions;
-
-    public function __construct(bool $throwExceptions = true)
-    {
-        $this->throwExceptions = $throwExceptions;
+    public function __construct(
+        private bool $throwExceptions = true,
+    ) {
     }
 
     protected function processValue(mixed $value, bool $isRoot = false): mixed

src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php

@@ -61,20 +61,17 @@ final class CheckTypeDeclarationsPass extends AbstractRecursivePass
         'string' => true,
     ];
 
-    private bool $autoload;
-    private array $skippedIds;
-
     private ExpressionLanguage $expressionLanguage;
 
     /**
      * @param bool  $autoload   Whether services who's class in not loaded should be checked or not.
      *                          Defaults to false to save loading code during compilation.
      * @param array $skippedIds An array indexed by the service ids to skip
      */
-    public function __construct(bool $autoload = false, array $skippedIds = [])
-    {
-        $this->autoload = $autoload;
-        $this->skippedIds = $skippedIds;
+    public function __construct(
+        private bool $autoload = false,
+        private array $skippedIds = [],
+    ) {
     }
 
     protected function processValue(mixed $value, bool $isRoot = false): mixed

src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php

@@ -26,17 +26,16 @@ class InlineServiceDefinitionsPass extends AbstractRecursivePass
 {
     protected bool $skipScalars = true;
 
-    private ?AnalyzeServiceReferencesPass $analyzingPass;
     private array $cloningIds = [];
     private array $connectedIds = [];
     private array $notInlinedIds = [];
     private array $inlinedIds = [];
     private array $notInlinableIds = [];
     private ?ServiceReferenceGraph $graph = null;
 
-    public function __construct(?AnalyzeServiceReferencesPass $analyzingPass = null)
-    {
-        $this->analyzingPass = $analyzingPass;
+    public function __construct(
+        private ?AnalyzeServiceReferencesPass $analyzingPass = null,
+    ) {
     }
 
     public function process(ContainerBuilder $container): void