Merge branch '5.4' into 6.4

* 5.4:
  Fix Twig deprecation notice
  [DependencyInjection] Fix issue between decorator and service locator index
  do not overwrite the host to request

Author: xabbuh

src/Symfony/Bridge/Twig/Tests/NodeVisitor/TwigNodeProvider.php

@@ -28,7 +28,7 @@ class TwigNodeProvider
     public static function getModule($content)
     {
         return new ModuleNode(
-            new ConstantExpression($content, 0),
+            new BodyNode([new ConstantExpression($content, 0)]),
             null,
             new ArrayExpression([], 0),
             new ArrayExpression([], 0),

src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php

@@ -85,7 +85,8 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
                 } elseif (null === $defaultIndex && $defaultPriorityMethod && $class) {
                     $defaultIndex = PriorityTaggedServiceUtil::getDefault($container, $serviceId, $class, $defaultIndexMethod ?? 'getDefaultName', $tagName, $indexAttribute, $checkTaggedItem);
                 }
-                $index ??= $defaultIndex ??= $serviceId;
+                $decorated = $definition->getTag('container.decorator')[0]['id'] ?? null;
+                $index = $index ?? $defaultIndex ?? $defaultIndex = $decorated ?? $serviceId;
 
                 $services[] = [$priority, ++$i, $index, $serviceId, $class];
             }

src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php

@@ -153,6 +153,9 @@ public function testTheIndexedTagsByDefaultIndexMethod()
 
         $container->register('service4', HelloInterface::class)->addTag('my_custom_tag');
 
+        $definition = $container->register('debug.service5', \stdClass::class)->addTag('my_custom_tag');
+        $definition->addTag('container.decorator', ['id' => 'service5']);
+
         $priorityTaggedServiceTraitImplementation = new PriorityTaggedServiceTraitImplementation();
 
         $tag = new TaggedIteratorArgument('my_custom_tag', 'foo', 'getFooBar');
@@ -161,6 +164,7 @@ public function testTheIndexedTagsByDefaultIndexMethod()
             'service1' => new TypedReference('service1', FooTagClass::class),
             '10' => new TypedReference('service3', IntTagClass::class),
             'service4' => new TypedReference('service4', HelloInterface::class),
+            'service5' => new TypedReference('debug.service5', \stdClass::class),
         ];
         $services = $priorityTaggedServiceTraitImplementation->test($tag, $container);
         $this->assertSame(array_keys($expected), array_keys($services));

src/Symfony/Component/HttpClient/CurlHttpClient.php

@@ -188,10 +188,10 @@ public function request(string $method, string $url, array $options = []): Respo
                 $multi->reset();
             }
 
-            foreach ($options['resolve'] as $host => $ip) {
-                $resolve[] = null === $ip ? "-$host:$port" : "$host:$port:$ip";
-                $multi->dnsCache->hostnames[$host] = $ip;
-                $multi->dnsCache->removals["-$host:$port"] = "-$host:$port";
+            foreach ($options['resolve'] as $resolveHost => $ip) {
+                $resolve[] = null === $ip ? "-$resolveHost:$port" : "$resolveHost:$port:$ip";
+                $multi->dnsCache->hostnames[$resolveHost] = $ip;
+                $multi->dnsCache->removals["-$resolveHost:$port"] = "-$resolveHost:$port";
             }
 
             $curlopts[\CURLOPT_RESOLVE] = $resolve;

src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php

@@ -122,4 +122,20 @@ public function testOverridingInternalAttributesUsingCurlOptions()
             ],
         ]);
     }
+
+    public function testKeepAuthorizationHeaderOnRedirectToSameHostWithConfiguredHostToIpAddressMapping()
+    {
+        $httpClient = $this->getHttpClient(__FUNCTION__);
+        $response = $httpClient->request('POST', 'http://127.0.0.1:8057/301', [
+            'headers' => [
+                'Authorization' => 'Basic Zm9vOmJhcg==',
+            ],
+            'resolve' => [
+                'symfony.com' => '10.10.10.10',
+            ],
+        ]);
+
+        $this->assertSame(200, $response->getStatusCode());
+        $this->assertSame('/302', $response->toArray()['REQUEST_URI'] ?? null);
+    }
 }