minor symfony#58600 Remove always true/false occurrences (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

Remove always true/false occurrences

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Most occurrences are surely artifact of when PHP allowed less typing.

Commits
-------

6980384 Remove always true/false occurrences

Author: nicolas-grekas

src/Symfony/Bridge/Doctrine/Security/User/EntityUserProvider.php

@@ -121,7 +121,7 @@ public function upgradePassword(PasswordAuthenticatedUserInterface $user, string
         }
 
         $repository = $this->getRepository();
-        if ($user instanceof PasswordAuthenticatedUserInterface && $repository instanceof PasswordUpgraderInterface) {
+        if ($repository instanceof PasswordUpgraderInterface) {
             $repository->upgradePassword($user, $newHashedPassword);
         }
     }

src/Symfony/Bridge/Twig/Command/DebugCommand.php

@@ -412,7 +412,6 @@ private function findWrongBundleOverrides(): array
         }
 
         if ($notFoundBundles = array_diff_key($bundleNames, $this->bundlesMetadata)) {
-            $alternatives = [];
             foreach ($notFoundBundles as $notFoundBundle => $path) {
                 $alternatives[$path] = $this->findAlternatives($notFoundBundle, array_keys($this->bundlesMetadata));
             }

src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php

@@ -172,7 +172,7 @@ protected function describeContainerService(object $service, array $options = []
             $options['output']->table(
                 ['Service ID', 'Class'],
                 [
-                    [$options['id'] ?? '-', $service::class],
+                    [$options['id'], $service::class],
                 ]
             );
         }
@@ -333,7 +333,7 @@ protected function describeContainerDefinition(Definition $definition, array $op
         $tableRows[] = ['Autoconfigured', $definition->isAutoconfigured() ? 'yes' : 'no'];
 
         if ($definition->getFile()) {
-            $tableRows[] = ['Required File', $definition->getFile() ?: '-'];
+            $tableRows[] = ['Required File', $definition->getFile()];
         }
 
         if ($factory = $definition->getFactory()) {

src/Symfony/Bundle/FrameworkBundle/Tests/Command/XliffLintCommandTest.php

@@ -64,9 +64,7 @@ private function createCommandTester($application = null): CommandTester
 
         $command = $application->find('lint:xliff');
 
-        if ($application) {
-            $command->setApplication($application);
-        }
+        $command->setApplication($application);
 
         return new CommandTester($command);
     }

src/Symfony/Bundle/FrameworkBundle/Tests/Command/YamlLintCommandTest.php

@@ -112,9 +112,7 @@ private function createCommandTester($application = null): CommandTester
 
         $command = $application->find('lint:yaml');
 
-        if ($application) {
-            $command->setApplication($application);
-        }
+        $command->setApplication($application);
 
         return new CommandTester($command);
     }

src/Symfony/Bundle/SecurityBundle/DependencyInjection/Compiler/ReplaceDecoratedRememberMeHandlerPass.php

@@ -37,9 +37,6 @@ public function process(ContainerBuilder $container): void
 
             // get the actual custom remember me handler definition (passed to the decorator)
             $realRememberMeHandler = $container->findDefinition((string) $definition->getArgument(0));
-            if (null === $realRememberMeHandler) {
-                throw new \LogicException(\sprintf('Invalid service definition for custom remember me handler; no service found with ID "%s".', (string) $definition->getArgument(0)));
-            }
 
             foreach ($rememberMeHandlerTags as $rememberMeHandlerTag) {
                 // some custom handlers may be used on multiple firewalls in the same application

src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/SecuredPageBundle/Security/Core/User/ArrayUserProvider.php

@@ -12,7 +12,6 @@
 namespace Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\SecuredPageBundle\Security\Core\User;
 
 use Symfony\Bundle\SecurityBundle\Tests\Functional\UserWithoutEquatable;
-use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
 use Symfony\Component\Security\Core\Exception\UserNotFoundException;
 use Symfony\Component\Security\Core\User\InMemoryUser;
 use Symfony\Component\Security\Core\User\UserInterface;
@@ -59,10 +58,6 @@ public function loadUserByIdentifier(string $identifier): UserInterface
 
     public function refreshUser(UserInterface $user): UserInterface
     {
-        if (!$user instanceof UserInterface) {
-            throw new UnsupportedUserException(\sprintf('Instances of "%s" are not supported.', get_debug_type($user)));
-        }
-
         $storedUser = $this->getUser($user->getUserIdentifier());
         $class = $storedUser::class;
 

src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php

@@ -207,12 +207,10 @@ public function clear(string $prefix = ''): bool
                     unset($this->deferred[$key]);
                 }
             }
-        } else {
-            $this->deferred = [];
-        }
 
-        if ($this->pool instanceof AdapterInterface) {
             return $this->pool->clear($prefix);
+        } else {
+            $this->deferred = [];
         }
 
         return $this->pool->clear();

src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php

@@ -108,7 +108,6 @@ private function write(string $file, string $data, ?int $expiresAt = null): bool
 
             if ('\\' === \DIRECTORY_SEPARATOR) {
                 $success = copy($tmp, $file);
-                $unlink = true;
             } else {
                 $success = rename($tmp, $file);
                 $unlink = !$success;

src/Symfony/Component/Cache/Traits/RedisTrait.php

@@ -199,7 +199,7 @@ public static function createConnection(#[\SensitiveParameter] string $dsn, arra
                 \extension_loaded('relay') => Relay::class,
                 default => \Predis\Client::class,
             },
-            1 < \count($hosts) && \extension_loaded('redis') => 1 < \count($hosts) ? \RedisArray::class : \Redis::class,
+            1 < \count($hosts) && \extension_loaded('redis') => \RedisArray::class,
             \extension_loaded('redis') => \Redis::class,
             \extension_loaded('relay') => Relay::class,
             default => \Predis\Client::class,
@@ -614,7 +614,7 @@ private function pipeline(\Closure $generator, ?object $redis = null): \Generato
                 }
             });
         } elseif ($redis instanceof \RedisArray) {
-            $connections = $results = $ids = [];
+            $connections = $results = [];
             foreach ($generator() as $command => $args) {
                 $id = 'eval' === $command ? $args[1][0] : $args[0];
                 if (!isset($connections[$h = $redis->_target($id)])) {