Skip to content

Commit 366604d

Browse files
committed
implement NodeVisitorInterface instead of extending AbstractNodeVisitor
1 parent 6a1c9ae commit 366604d

File tree

2 files changed

+8
-20
lines changed

2 files changed

+8
-20
lines changed

src/Symfony/Bridge/Twig/NodeVisitor/TranslationDefaultDomainNodeVisitor.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
use Twig\Node\ModuleNode;
2424
use Twig\Node\Node;
2525
use Twig\Node\SetNode;
26-
use Twig\NodeVisitor\AbstractNodeVisitor;
26+
use Twig\NodeVisitor\NodeVisitorInterface;
2727

2828
/**
2929
* @author Fabien Potencier <fabien@symfony.com>
3030
*/
31-
final class TranslationDefaultDomainNodeVisitor extends AbstractNodeVisitor
31+
final class TranslationDefaultDomainNodeVisitor implements NodeVisitorInterface
3232
{
3333
private $scope;
3434

@@ -37,10 +37,7 @@ public function __construct()
3737
$this->scope = new Scope();
3838
}
3939

40-
/**
41-
* {@inheritdoc}
42-
*/
43-
protected function doEnterNode(Node $node, Environment $env): Node
40+
public function enterNode(Node $node, Environment $env): Node
4441
{
4542
if ($node instanceof BlockNode || $node instanceof ModuleNode) {
4643
$this->scope = $this->scope->enter();
@@ -86,10 +83,7 @@ protected function doEnterNode(Node $node, Environment $env): Node
8683
return $node;
8784
}
8885

89-
/**
90-
* {@inheritdoc}
91-
*/
92-
protected function doLeaveNode(Node $node, Environment $env): ?Node
86+
public function leaveNode(Node $node, Environment $env): ?Node
9387
{
9488
if ($node instanceof TransDefaultDomainNode) {
9589
return null;

src/Symfony/Bridge/Twig/NodeVisitor/TranslationNodeVisitor.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818
use Twig\Node\Expression\FilterExpression;
1919
use Twig\Node\Expression\FunctionExpression;
2020
use Twig\Node\Node;
21-
use Twig\NodeVisitor\AbstractNodeVisitor;
21+
use Twig\NodeVisitor\NodeVisitorInterface;
2222

2323
/**
2424
* TranslationNodeVisitor extracts translation messages.
2525
*
2626
* @author Fabien Potencier <fabien@symfony.com>
2727
*/
28-
final class TranslationNodeVisitor extends AbstractNodeVisitor
28+
final class TranslationNodeVisitor implements NodeVisitorInterface
2929
{
3030
public const UNDEFINED_DOMAIN = '_undefined';
3131

@@ -49,10 +49,7 @@ public function getMessages(): array
4949
return $this->messages;
5050
}
5151

52-
/**
53-
* {@inheritdoc}
54-
*/
55-
protected function doEnterNode(Node $node, Environment $env): Node
52+
public function enterNode(Node $node, Environment $env): Node
5653
{
5754
if (!$this->enabled) {
5855
return $node;
@@ -101,10 +98,7 @@ protected function doEnterNode(Node $node, Environment $env): Node
10198
return $node;
10299
}
103100

104-
/**
105-
* {@inheritdoc}
106-
*/
107-
protected function doLeaveNode(Node $node, Environment $env): ?Node
101+
public function leaveNode(Node $node, Environment $env): ?Node
108102
{
109103
return $node;
110104
}

0 commit comments

Comments
 (0)