Merge branch '6.4' into 7.1

* 6.4:
  [Serializer] Remove redundant @internal tags from traceable classes
  Fix conversion of partitioned cookies in the PSR-7 bridge
  [Validator] added Polish translation for units 116-119
  Revert stateless check
  [Console] Fix side-effects from running bash completions
  skip transient Redis integration tests on AppVeyor

Author: chalasr

src/Symfony/Bridge/PsrHttpMessage/Factory/HttpFoundationFactory.php

@@ -132,89 +132,12 @@ public function createResponse(ResponseInterface $psrResponse, bool $streamed =
         $response->setProtocolVersion($psrResponse->getProtocolVersion());
 
         foreach ($cookies as $cookie) {
-            $response->headers->setCookie($this->createCookie($cookie));
+            $response->headers->setCookie(Cookie::fromString($cookie));
         }
 
         return $response;
     }
 
-    /**
-     * Creates a Cookie instance from a cookie string.
-     *
-     * Some snippets have been taken from the Guzzle project: https://github.com/guzzle/guzzle/blob/5.3/src/Cookie/SetCookie.php#L34
-     *
-     * @throws \InvalidArgumentException
-     */
-    private function createCookie(string $cookie): Cookie
-    {
-        foreach (explode(';', $cookie) as $part) {
-            $part = trim($part);
-
-            $data = explode('=', $part, 2);
-            $name = $data[0];
-            $value = isset($data[1]) ? trim($data[1], " \n\r\t\0\x0B\"") : null;
-
-            if (!isset($cookieName)) {
-                $cookieName = $name;
-                $cookieValue = $value;
-
-                continue;
-            }
-
-            if ('expires' === strtolower($name) && null !== $value) {
-                $cookieExpire = new \DateTime($value);
-
-                continue;
-            }
-
-            if ('path' === strtolower($name) && null !== $value) {
-                $cookiePath = $value;
-
-                continue;
-            }
-
-            if ('domain' === strtolower($name) && null !== $value) {
-                $cookieDomain = $value;
-
-                continue;
-            }
-
-            if ('secure' === strtolower($name)) {
-                $cookieSecure = true;
-
-                continue;
-            }
-
-            if ('httponly' === strtolower($name)) {
-                $cookieHttpOnly = true;
-
-                continue;
-            }
-
-            if ('samesite' === strtolower($name) && null !== $value) {
-                $samesite = $value;
-
-                continue;
-            }
-        }
-
-        if (!isset($cookieName)) {
-            throw new \InvalidArgumentException('The value of the Set-Cookie header is malformed.');
-        }
-
-        return new Cookie(
-            $cookieName,
-            $cookieValue,
-            $cookieExpire ?? 0,
-            $cookiePath ?? '/',
-            $cookieDomain ?? null,
-            isset($cookieSecure),
-            isset($cookieHttpOnly),
-            true,
-            $samesite ?? null
-        );
-    }
-
     private function createStreamedResponseCallback(StreamInterface $body): callable
     {
         return function () use ($body) {

src/Symfony/Component/Console/Resources/completion.bash

@@ -17,7 +17,7 @@ _sf_{{ COMMAND_NAME }}() {
     done
 
     # Use newline as only separator to allow space in completion values
-    IFS=$'\n'
+    local IFS=$'\n'
     local sf_cmd="${COMP_WORDS[0]}"
 
     # for an alias, get the real script behind it

src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisExtIntegrationTest.php

@@ -372,6 +372,9 @@ public function testGetNonBlocking()
         }
     }
 
+    /**
+     * @group transient-on-windows
+     */
     public function testGetAfterReject()
     {
         $redis = $this->createRedisClient();

src/Symfony/Component/Security/Http/Firewall/ContextListener.php

@@ -87,7 +87,8 @@ public function authenticate(RequestEvent $event): void
         }
 
         $request = $event->getRequest();
-        $session = !$request->attributes->getBoolean('_stateless') && $request->hasPreviousSession() ? $request->getSession() : null;
+        $session = $request->hasPreviousSession() ? $request->getSession() : null;
+
 
         $request->attributes->set('_security_firewall_run', $this->sessionKey);
 

src/Symfony/Component/Serializer/DataCollector/SerializerDataCollector.php

@@ -21,7 +21,7 @@
 /**
  * @author Mathias Arlaud <mathias.arlaud@gmail.com>
  *
- * @internal
+ * @final
  */
 class SerializerDataCollector extends DataCollector implements LateDataCollectorInterface
 {

src/Symfony/Component/Serializer/Debug/TraceableEncoder.php

@@ -23,7 +23,7 @@
  *
  * @author Mathias Arlaud <mathias.arlaud@gmail.com>
  *
- * @internal
+ * @final
  */
 class TraceableEncoder implements EncoderInterface, DecoderInterface, SerializerAwareInterface
 {

src/Symfony/Component/Serializer/Debug/TraceableNormalizer.php

@@ -24,7 +24,7 @@
  *
  * @author Mathias Arlaud <mathias.arlaud@gmail.com>
  *
- * @internal
+ * @final
  */
 class TraceableNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, NormalizerAwareInterface, DenormalizerAwareInterface
 {

src/Symfony/Component/Serializer/Debug/TraceableSerializer.php

@@ -23,7 +23,7 @@
  *
  * @author Mathias Arlaud <mathias.arlaud@gmail.com>
  *
- * @internal
+ * @final
  */
 class TraceableSerializer implements SerializerInterface, NormalizerInterface, DenormalizerInterface, EncoderInterface, DecoderInterface
 {

src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf

@@ -452,19 +452,19 @@
             </trans-unit>
             <trans-unit id="116">
                 <source>This value does not represent a valid week in the ISO 8601 format.</source>
-                <target state="needs-translation">This value does not represent a valid week in the ISO 8601 format.</target>
+                <target>Podana wartość nie jest poprawnym oznaczeniem tygodnia w formacie ISO 8601.</target>
             </trans-unit>
             <trans-unit id="117">
                 <source>This value is not a valid week.</source>
-                <target state="needs-translation">This value is not a valid week.</target>
+                <target>Podana wartość nie jest poprawnym oznaczeniem tygodnia.</target>
             </trans-unit>
             <trans-unit id="118">
                 <source>This value should not be before week "{{ min }}".</source>
-                <target state="needs-translation">This value should not be before week "{{ min }}".</target>
+                <target>Podana wartość nie powinna być przed tygodniem "{{ min }}".</target>
             </trans-unit>
             <trans-unit id="119">
                 <source>This value should not be after week "{{ max }}".</source>
-                <target state="needs-translation">This value should not be after week "{{ max }}".</target>
+                <target>Podana wartość nie powinna być po tygodniu "{{ max }}".</target>
             </trans-unit>
         </body>
     </file>