minor symfony#57926 [AssetMaper] Fix entropy of hash in public path (nicolas-grekas)

This PR was merged into the 7.2 branch.

Discussion
----------

[AssetMaper] Fix entropy of hash in public path

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #
| License       | MIT

$digest is already in hexa. Turning it in base64 requires first making it binary. Also, we have to use the url-safe variant of base64.

Commits
-------

b7a860f [AssetMaper] Fix entropy of hash in public path

Author: fabpot

src/Symfony/Component/AssetMapper/Factory/MappedAssetFactory.php

@@ -116,9 +116,10 @@ private function getPublicPath(MappedAsset $asset, ?string $content): ?string
         if ($isPredigested) {
             return $this->assetsPathResolver->resolvePublicPath($asset->logicalPath);
         }
-
-        $digest = substr(base64_encode($digest), 0, self::PUBLIC_DIGEST_LENGTH);
-        $digestedPath = preg_replace_callback('/\.(\w+)$/', fn ($matches) => "-{$digest}{$matches[0]}", $asset->logicalPath);
+        $digest = base64_encode(hex2bin($digest));
+        $digest = substr($digest, 0, self::PUBLIC_DIGEST_LENGTH);
+        $digest = strtr($digest, '+/', '-_');
+        $digestedPath = preg_replace('/\.(\w+)$/', "-{$digest}\\0", $asset->logicalPath);
 
         return $this->assetsPathResolver->resolvePublicPath($digestedPath);
     }

src/Symfony/Component/AssetMapper/Tests/AssetMapperDevServerSubscriberFunctionalTest.php

@@ -21,7 +21,7 @@ public function testGettingAssetWorks()
     {
         $client = static::createClient();
 
-        $client->request('GET', '/assets/file1-YjM0NDV.css');
+        $client->request('GET', '/assets/file1-s0Rct6h.css');
         $response = $client->getResponse();
         $this->assertSame(200, $response->getStatusCode());
         $this->assertInstanceOf(BinaryFileResponse::class, $response);
@@ -39,7 +39,7 @@ public function testGettingAssetWithNonAsciiFilenameWorks()
     {
         $client = static::createClient();
 
-        $client->request('GET', '/assets/voilà-NjM0NDQ.css');
+        $client->request('GET', '/assets/voilà-Y0RCLaa.css');
         $response = $client->getResponse();
         $this->assertSame(200, $response->getStatusCode());
         $this->assertSame(<<<EOF

src/Symfony/Component/AssetMapper/Tests/Command/AssetMapperCompileCommandTest.php

@@ -59,12 +59,12 @@ public function testAssetsAreCompiled()
         // match Compiling \d+ assets
         $this->assertMatchesRegularExpression('/Compiled \d+ assets/', $tester->getDisplay());
 
-        $this->assertFileExists($targetBuildDir.'/subdir/file5-ZjRmZGM.js');
+        $this->assertFileExists($targetBuildDir.'/subdir/file5-9P3Dc3X.js');
         $this->assertSame(<<<EOF
         import '../file4.js';
         console.log('file5.js');
 
-        EOF, $this->filesystem->readFile($targetBuildDir.'/subdir/file5-ZjRmZGM.js'));
+        EOF, $this->filesystem->readFile($targetBuildDir.'/subdir/file5-9P3Dc3X.js'));
 
         $finder = new Finder();
         $finder->in($targetBuildDir)->files();

src/Symfony/Component/AssetMapper/Tests/MapperAwareAssetPackageIntegrationTest.php

@@ -37,7 +37,7 @@ public function testDefaultAssetPackageIsDecorated()
     {
         $packages = $this->kernel->getContainer()->get('public.assets.packages');
         \assert($packages instanceof Packages);
-        $this->assertSame('/assets/file1-YjM0NDV.css', $packages->getUrl('file1.css'));
+        $this->assertSame('/assets/file1-s0Rct6h.css', $packages->getUrl('file1.css'));
         $this->assertSame('/non-existent.css', $packages->getUrl('non-existent.css'));
     }
 }