minor symfony#57304 [Security] use constructor property promotion (xabbuh)

This PR was merged into the 7.2 branch.

Discussion
----------

[Security] use constructor property promotion

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

b1e4439 use constructor property promotion

Author: fabpot

src/Symfony/Component/Security/Core/Authentication/RememberMe/CacheTokenVerifier.php

@@ -18,21 +18,17 @@
  */
 class CacheTokenVerifier implements TokenVerifierInterface
 {
-    private CacheItemPoolInterface $cache;
-    private int $outdatedTokenTtl;
-    private string $cacheKeyPrefix;
-
     /**
      * @param int $outdatedTokenTtl How long the outdated token should still be considered valid. Defaults
      *                              to 60, which matches how often the PersistentRememberMeHandler will at
      *                              most refresh tokens. Increasing to more than that is not recommended,
      *                              but you may use a lower value.
      */
-    public function __construct(CacheItemPoolInterface $cache, int $outdatedTokenTtl = 60, string $cacheKeyPrefix = 'rememberme-stale-')
-    {
-        $this->cache = $cache;
-        $this->outdatedTokenTtl = $outdatedTokenTtl;
-        $this->cacheKeyPrefix = $cacheKeyPrefix;
+    public function __construct(
+        private CacheItemPoolInterface $cache,
+        private int $outdatedTokenTtl = 60,
+        private string $cacheKeyPrefix = 'rememberme-stale-',
+    ) {
     }
 
     public function verifyToken(PersistentTokenInterface $token, #[\SensitiveParameter] string $tokenValue): bool

src/Symfony/Component/Security/Core/Authentication/RememberMe/PersistentToken.php

@@ -18,14 +18,15 @@
  */
 final class PersistentToken implements PersistentTokenInterface
 {
-    private string $class;
-    private string $userIdentifier;
-    private string $series;
-    private string $tokenValue;
     private \DateTimeImmutable $lastUsed;
 
-    public function __construct(string $class, string $userIdentifier, string $series, #[\SensitiveParameter] string $tokenValue, \DateTimeInterface $lastUsed)
-    {
+    public function __construct(
+        private string $class,
+        private string $userIdentifier,
+        private string $series,
+        #[\SensitiveParameter] private string $tokenValue,
+        \DateTimeInterface $lastUsed,
+    ) {
         if (!$class) {
             throw new \InvalidArgumentException('$class must not be empty.');
         }
@@ -39,10 +40,6 @@ public function __construct(string $class, string $userIdentifier, string $serie
             throw new \InvalidArgumentException('$tokenValue must not be empty.');
         }
 
-        $this->class = $class;
-        $this->userIdentifier = $userIdentifier;
-        $this->series = $series;
-        $this->tokenValue = $tokenValue;
         $this->lastUsed = \DateTimeImmutable::createFromInterface($lastUsed);
     }
 

src/Symfony/Component/Security/Core/Authentication/Token/PreAuthenticatedToken.php

@@ -20,21 +20,21 @@
  */
 class PreAuthenticatedToken extends AbstractToken
 {
-    private string $firewallName;
-
     /**
      * @param string[] $roles
      */
-    public function __construct(UserInterface $user, string $firewallName, array $roles = [])
-    {
+    public function __construct(
+        UserInterface $user,
+        private string $firewallName,
+        array $roles = [],
+    ) {
         parent::__construct($roles);
 
         if ('' === $firewallName) {
             throw new \InvalidArgumentException('$firewallName must not be empty.');
         }
 
         $this->setUser($user);
-        $this->firewallName = $firewallName;
     }
 
     public function getFirewallName(): string

src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php

@@ -22,13 +22,14 @@
 class RememberMeToken extends AbstractToken
 {
     private ?string $secret = null;
-    private string $firewallName;
 
     /**
      * @throws \InvalidArgumentException
      */
-    public function __construct(UserInterface $user, string $firewallName)
-    {
+    public function __construct(
+        UserInterface $user,
+        private string $firewallName,
+    ) {
         parent::__construct($user->getRoles());
 
         if (\func_num_args() > 2) {
@@ -40,8 +41,6 @@ public function __construct(UserInterface $user, string $firewallName)
             throw new InvalidArgumentException('$firewallName must not be empty.');
         }
 
-        $this->firewallName = $firewallName;
-
         $this->setUser($user);
     }
 

src/Symfony/Component/Security/Core/Authentication/Token/Storage/UsageTrackingTokenStorage.php

@@ -24,14 +24,12 @@
  */
 final class UsageTrackingTokenStorage implements TokenStorageInterface, ServiceSubscriberInterface
 {
-    private TokenStorageInterface $storage;
-    private ContainerInterface $container;
     private bool $enableUsageTracking = false;
 
-    public function __construct(TokenStorageInterface $storage, ContainerInterface $container)
-    {
-        $this->storage = $storage;
-        $this->container = $container;
+    public function __construct(
+        private TokenStorageInterface $storage,
+        private ContainerInterface $container,
+    ) {
     }
 
     public function getToken(): ?TokenInterface

src/Symfony/Component/Security/Core/Authentication/Token/SwitchUserToken.php

@@ -20,7 +20,6 @@
  */
 class SwitchUserToken extends UsernamePasswordToken
 {
-    private TokenInterface $originalToken;
     private ?string $originatedFromUri = null;
 
     /**
@@ -29,11 +28,15 @@ class SwitchUserToken extends UsernamePasswordToken
      *
      * @throws \InvalidArgumentException
      */
-    public function __construct(UserInterface $user, string $firewallName, array $roles, TokenInterface $originalToken, ?string $originatedFromUri = null)
-    {
+    public function __construct(
+        UserInterface $user,
+        string $firewallName,
+        array $roles,
+        private TokenInterface $originalToken,
+        ?string $originatedFromUri = null,
+    ) {
         parent::__construct($user, $firewallName, $roles);
 
-        $this->originalToken = $originalToken;
         $this->originatedFromUri = $originatedFromUri;
     }
 

src/Symfony/Component/Security/Core/Authentication/Token/UsernamePasswordToken.php

@@ -20,18 +20,18 @@
  */
 class UsernamePasswordToken extends AbstractToken
 {
-    private string $firewallName;
-
-    public function __construct(UserInterface $user, string $firewallName, array $roles = [])
-    {
+    public function __construct(
+        UserInterface $user,
+        private string $firewallName,
+        array $roles = [],
+    ) {
         parent::__construct($roles);
 
         if ('' === $firewallName) {
             throw new \InvalidArgumentException('$firewallName must not be empty.');
         }
 
         $this->setUser($user);
-        $this->firewallName = $firewallName;
     }
 
     public function getFirewallName(): string

src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php

@@ -32,17 +32,17 @@ final class AccessDecisionManager implements AccessDecisionManagerInterface
         VoterInterface::ACCESS_ABSTAIN => true,
     ];
 
-    private iterable $voters;
     private array $votersCacheAttributes = [];
     private array $votersCacheObject = [];
     private AccessDecisionStrategyInterface $strategy;
 
     /**
      * @param iterable<mixed, VoterInterface> $voters An array or an iterator of VoterInterface instances
      */
-    public function __construct(iterable $voters = [], ?AccessDecisionStrategyInterface $strategy = null)
-    {
-        $this->voters = $voters;
+    public function __construct(
+        private iterable $voters = [],
+        ?AccessDecisionStrategyInterface $strategy = null,
+    ) {
         $this->strategy = $strategy ?? new AffirmativeStrategy();
     }
 

src/Symfony/Component/Security/Core/Authorization/Strategy/AffirmativeStrategy.php

@@ -24,11 +24,9 @@
  */
 final class AffirmativeStrategy implements AccessDecisionStrategyInterface, \Stringable
 {
-    private bool $allowIfAllAbstainDecisions;
-
-    public function __construct(bool $allowIfAllAbstainDecisions = false)
-    {
-        $this->allowIfAllAbstainDecisions = $allowIfAllAbstainDecisions;
+    public function __construct(
+        private bool $allowIfAllAbstainDecisions = false,
+    ) {
     }
 
     public function decide(\Traversable $results): bool

src/Symfony/Component/Security/Core/Authorization/Strategy/ConsensusStrategy.php

@@ -32,13 +32,10 @@
  */
 final class ConsensusStrategy implements AccessDecisionStrategyInterface, \Stringable
 {
-    private bool $allowIfAllAbstainDecisions;
-    private bool $allowIfEqualGrantedDeniedDecisions;
-
-    public function __construct(bool $allowIfAllAbstainDecisions = false, bool $allowIfEqualGrantedDeniedDecisions = true)
-    {
-        $this->allowIfAllAbstainDecisions = $allowIfAllAbstainDecisions;
-        $this->allowIfEqualGrantedDeniedDecisions = $allowIfEqualGrantedDeniedDecisions;
+    public function __construct(
+        private bool $allowIfAllAbstainDecisions = false,
+        private bool $allowIfEqualGrantedDeniedDecisions = true,
+    ) {
     }
 
     public function decide(\Traversable $results): bool