feature symfony#53866 [Workflow] determines places from transitions (lyrixx)

This PR was merged into the 7.1 branch.

Discussion
----------

[Workflow] determines places from transitions

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | Fix symfony#52378
| License       | MIT

Commits
-------

ed30d81 [workflow] determines places form transitions

Author: fabpot

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

@@ -484,8 +484,6 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode): void
                                                 return array_values($places);
                                             })
                                         ->end()
-                                        ->isRequired()
-                                        ->requiresAtLeastOneElement()
                                         ->prototype('array')
                                             ->children()
                                                 ->scalarNode('name')

src/Symfony/Component/Workflow/CHANGELOG.md

@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add method `getEnabledTransition()` to `WorkflowInterface`
+ * Automatically register places from transitions
 
 7.0
 ---

src/Symfony/Component/Workflow/Definition.php

@@ -104,17 +104,15 @@ private function addPlace(string $place): void
 
     private function addTransition(Transition $transition): void
     {
-        $name = $transition->getName();
-
         foreach ($transition->getFroms() as $from) {
-            if (!isset($this->places[$from])) {
-                throw new LogicException(sprintf('Place "%s" referenced in transition "%s" does not exist.', $from, $name));
+            if (!\array_key_exists($from, $this->places)) {
+                $this->addPlace($from);
             }
         }
 
         foreach ($transition->getTos() as $to) {
-            if (!isset($this->places[$to])) {
-                throw new LogicException(sprintf('Place "%s" referenced in transition "%s" does not exist.', $to, $name));
+            if (!\array_key_exists($to, $this->places)) {
+                $this->addPlace($to);
             }
         }
 

src/Symfony/Component/Workflow/Tests/DefinitionTest.php

@@ -66,19 +66,15 @@ public function testAddTransitionAndFromPlaceIsNotDefined()
     {
         $places = range('a', 'b');
 
-        $this->expectException(LogicException::class);
-        $this->expectExceptionMessage('Place "c" referenced in transition "name" does not exist.');
-
-        new Definition($places, [new Transition('name', 'c', $places[1])]);
+        $definition = new Definition($places, [new Transition('name', 'c', $places[1])]);
+        $this->assertContains('c', $definition->getPlaces());
     }
 
     public function testAddTransitionAndToPlaceIsNotDefined()
     {
         $places = range('a', 'b');
 
-        $this->expectException(LogicException::class);
-        $this->expectExceptionMessage('Place "c" referenced in transition "name" does not exist.');
-
-        new Definition($places, [new Transition('name', $places[0], 'c')]);
+        $definition = new Definition($places, [new Transition('name', $places[0], 'c')]);
+        $this->assertContains('c', $definition->getPlaces());
     }
 }