Encore.configureUrlLoader() - Move url-loader to dev dependencies

Author: Lyrkan

lib/config-generator.js

@@ -11,6 +11,7 @@
 
 const extractText = require('./loaders/extract-text');
 const pathUtil = require('./config/path-util');
+const loaderFeatures = require('./features');
 // loaders utils
 const cssLoaderUtil = require('./loaders/css');
 const sassLoaderUtil = require('./loaders/sass');
@@ -158,6 +159,7 @@ class ConfigGenerator {
             };
 
             if (this.webpackConfig.urlLoaderOptions.images) {
+                loaderFeatures.ensurePackagesExist('urlloader');
                 loaderName = 'url-loader';
                 Object.assign(loaderOptions, this.webpackConfig.urlLoaderOptions.images);
             }
@@ -185,6 +187,7 @@ class ConfigGenerator {
             };
 
             if (this.webpackConfig.urlLoaderOptions.fonts) {
+                loaderFeatures.ensurePackagesExist('urlloader');
                 loaderName = 'url-loader';
                 Object.assign(loaderOptions, this.webpackConfig.urlLoaderOptions.fonts);
             }

lib/features.js

@@ -72,6 +72,11 @@ const features = {
         method: 'enableBuildNotifications()',
         packages: ['webpack-notifier'],
         description: 'display build notifications'
+    },
+    urlloader: {
+        method: 'configureUrlLoader()',
+        packages: ['url-loader'],
+        description: 'use the url-loader'
     }
 };
 

package.json

@@ -43,7 +43,6 @@
     "pretty-error": "^2.1.1",
     "resolve-url-loader": "^2.0.2",
     "style-loader": "^0.13.2",
-    "url-loader": "^1.0.1",
     "webpack": ">=2.2.0 <4",
     "webpack-chunk-hash": "^0.5.0",
     "webpack-dev-server": "^2.4.5",
@@ -77,6 +76,7 @@
     "stylus-loader": "^3.0.1",
     "ts-loader": "^2.1.0",
     "typescript": "^2.3.4",
+    "url-loader": "^1.0.1",
     "vue": "^2.3.4",
     "vue-loader": "^12.2.1",
     "vue-template-compiler": "^2.3.4",

yarn.lock

@@ -4115,8 +4115,8 @@ mime@^1.2.11, mime@^1.3.4, mime@^1.5.0:
   resolved "https://registry.yarnpkg.com/mime/-/mime-1.6.0.tgz#32cd9e5c64553bd58d19a568af452acff04981b1"
 
 mime@^2.0.3:
-  version "2.2.2"
-  resolved "https://registry.yarnpkg.com/mime/-/mime-2.2.2.tgz#6b4c109d88031d7b5c23635f5b923da336d79121"
+  version "2.3.1"
+  resolved "https://registry.yarnpkg.com/mime/-/mime-2.3.1.tgz#b1621c54d63b97c47d3cfe7f7215f7d64517c369"
 
 mimic-fn@^1.0.0:
   version "1.2.0"