Skip to content

Commit 37c6b37

Browse files
committed
feature #983 Allow less-loader v9 (bobvandevijver, weaverryan)
This PR was merged into the main branch. Discussion ---------- Allow less-loader v9 I'm not sure what the policy on node compatibility is, but the latest major of `less-loader` only seems to drop Node 10 support ([release notes](https://github.com/webpack-contrib/less-loader/blob/master/CHANGELOG.md)). Webpack Encore still supports Node 10, but that should still be possible if you use one of the other allowed less loaders. Commits ------- 8ab906e working around node 10 and less-loader 9 in the test suite b5986ca Allow less-loader v9
2 parents 972c882 + 8ab906e commit 37c6b37

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

.github/workflows/node-windows.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ jobs:
1919
uses: actions/setup-node@v1
2020
with:
2121
node-version: ${{ matrix.node }}
22+
# needed so that Node 10 downloads a compatible less-loader version
23+
- name: Clear lock file
24+
run: del yarn.lock
2225
- name: yarn install
23-
run: yarn install
26+
run: yarn --ignore-engines
2427
- name: run tests
2528
run: yarn test

.travis.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,15 @@ matrix:
2626
- rm yarn.lock
2727
- yarn
2828
- os: linux
29-
node_js: "10"
29+
node_js: "14"
3030
env: JOB_PART=travis:lint
3131
- os: linux
3232
node_js: "10"
3333
env: JOB_PART=test
34+
# needed so that Node 10 downloads a compatible less-loader version
35+
install:
36+
- rm yarn.lock
37+
- yarn --ignore-engines
3438
- os: linux
3539
node_js: "12"
3640
env: JOB_PART=test

package.json

100644100755
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"handlebars-loader": "^1.7.0",
7979
"http-server": "^0.12.3",
8080
"less": "^4.0.0",
81-
"less-loader": "^7.0.0 || ^8.0.0",
81+
"less-loader": "^7.0.0 || ^8.0.0 || ^9.0.0",
8282
"mocha": "^8.2.1",
8383
"postcss": "^8.1.0",
8484
"postcss-loader": "^4.0.0 || ^5.0.0",

yarn.lock

100644100755
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4455,10 +4455,10 @@ left-pad@^1.3.0:
44554455
resolved "https://registry.yarnpkg.com/left-pad/-/left-pad-1.3.0.tgz#5b8a3a7765dfe001261dde915589e782f8c94d1e"
44564456
integrity sha512-XI5MPzVNApjAyhQzphX8BkmKsKUxD4LdyK24iZeQGinBN9yTQT3bFlCBy/aVx2HrNcqQGsdot8ghrjyrvMCoEA==
44574457

4458-
"less-loader@^7.0.0 || ^8.0.0":
4459-
version "8.1.1"
4460-
resolved "https://registry.yarnpkg.com/less-loader/-/less-loader-8.1.1.tgz#ababe912580457ad00a4318146aac5b53e023f42"
4461-
integrity sha512-K93jJU7fi3n6rxVvzp8Cb88Uy9tcQKfHlkoezHwKILXhlNYiRQl4yowLIkQqmBXOH/5I8yoKiYeIf781HGkW9g==
4458+
"less-loader@^7.0.0 || ^8.0.0 || ^9.0.0":
4459+
version "9.0.0"
4460+
resolved "https://registry.yarnpkg.com/less-loader/-/less-loader-9.0.0.tgz#71a0b530174bddf89bb11a5019dd725f54df4791"
4461+
integrity sha512-bPen1xeGTZuYFFobcdz9kMUVgSSSDZQJtyhawtCtcz1QboQOwhkI7uCwp5UO+IZpO+LJS1W73YwxsufbBT6SBQ==
44624462
dependencies:
44634463
klona "^2.0.4"
44644464

0 commit comments

Comments
 (0)