Merge branch '4.3' into 4.4

* 4.3:
  [HttpFoundation] Throw exception when the \"session\" extension is not loaded
  remove invalid test case
  remove invalid test cases
  [Serializer] Fixed PHP of DenormalizableInterface::denormalize
  [Cache] work aroung PHP memory leak
  [Finder] docblock fixes
  pass error code as a string
  Catch JsonException and rethrow in JsonEncode

Author: nicolas-grekas

Tests/Constraints/AbstractComparisonValidatorTestCase.php

@@ -148,20 +148,6 @@ public function testValidComparisonToPropertyPath($comparedValue)
         $this->assertNoViolation();
     }
 
-    /**
-     * @dataProvider provideValidComparisonsToPropertyPath
-     */
-    public function testValidComparisonToPropertyPathOnArray($comparedValue)
-    {
-        $constraint = $this->createConstraint(['propertyPath' => '[root][value]']);
-
-        $this->setObject(['root' => ['value' => 5]]);
-
-        $this->validator->validate($comparedValue, $constraint);
-
-        $this->assertNoViolation();
-    }
-
     public function testNoViolationOnNullObjectWithPropertyPath()
     {
         $constraint = $this->createConstraint(['propertyPath' => 'propertyPath']);

Tests/Constraints/BicValidatorTest.php

@@ -50,17 +50,6 @@ public function testValidComparisonToPropertyPath()
         $this->assertNoViolation();
     }
 
-    public function testValidComparisonToPropertyPathOnArray()
-    {
-        $constraint = new Bic(['ibanPropertyPath' => '[root][value]']);
-
-        $this->setObject(['root' => ['value' => 'FR14 2004 1010 0505 0001 3M02 606']]);
-
-        $this->validator->validate('SOGEFRPP', $constraint);
-
-        $this->assertNoViolation();
-    }
-
     public function testInvalidComparisonToPropertyPath()
     {
         $constraint = new Bic(['ibanPropertyPath' => 'value']);

Tests/Validator/AbstractTest.php

@@ -511,7 +511,7 @@ public function testAddCustomizedViolation()
                 ->setParameter('%param%', 'value')
                 ->setInvalidValue('Invalid value')
                 ->setPlural(2)
-                ->setCode(42)
+                ->setCode('42')
                 ->addViolation();
         };
 
@@ -528,7 +528,7 @@ public function testAddCustomizedViolation()
         $this->assertSame($entity, $violations[0]->getRoot());
         $this->assertSame('Invalid value', $violations[0]->getInvalidValue());
         $this->assertSame(2, $violations[0]->getPlural());
-        $this->assertSame(42, $violations[0]->getCode());
+        $this->assertSame('42', $violations[0]->getCode());
     }
 
     public function testNoDuplicateValidationIfClassConstraintInMultipleGroups()